Bug Fix: Prevent Duplicate Exit Animations in AnimatePresence#3384
Closed
seal7766 wants to merge 1 commit intomotiondivision:mainfrom
Closed
Bug Fix: Prevent Duplicate Exit Animations in AnimatePresence#3384seal7766 wants to merge 1 commit intomotiondivision:mainfrom
seal7766 wants to merge 1 commit intomotiondivision:mainfrom
Conversation
…ents - Add exit state tracking to prevent processing same component twice - Fix issues with Radix UI and other libraries triggering multiple events - Clean up tracking state appropriately on completion and re-entry
Collaborator
|
Thanks for the PR! Is it possible to get a test that fails on |
Author
|
@mattgperry Unfortunately, I couldn't reproduce the exact bug in tests because it requires:
While I couldn't provide a failing test, the fix is straightforward defensive Would you thoughts on this approach? |
Collaborator
|
@claude Please review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Collaborator
|
Thanks for this fix! It's been replaced by #3454 which also includes some failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix: Prevent Duplicate Exit Animations in AnimatePresence
📋 Problem
AnimatePresence component can process the same exit animation multiple times when receiving rapid sequential DOM events. This occurs when:
pointerdownevent)This is particularly common with UI libraries like Radix UI, where dismissable layers can fire multiple events in quick succession.
✨ Solution
Track components currently processing exit animations to prevent duplicate handling:
🔧 How It Works
onExitis called, check if the component is already being processed✅ Testing
🔗 Related Issues
Impact: Low risk, high value fix for production applications using AnimatePresence with modern UI libraries.