Skip to content

Conversation

@lgaspari
Copy link
Contributor

Fixes #3469

Summary

  • When closest scrollable element is either document.body or document.documentElement, then:
    • Max scroll is determined by window's innerWidth or innerHeight based on axis
    • Current scroll is determined by window's scrollX or scrollY based on axis
    • Scroll is performed on window invoking scrollBy method

Test plan

  • Cypress tests for reorder-auto-scroll pass
  • Manual testing with scrollable container
  • Verify existing Reorder functionality unchanged

Evidence

Screen.Recording.2026-01-23.at.19.25.14.mov

@lgaspari lgaspari force-pushed the feat/reorder-auto-scroll-page branch from d918b46 to 547d93e Compare January 26, 2026 14:04
@lgaspari
Copy link
Contributor Author

Hey @mattgperry, sorry for the direct ping. When you have a moment, would you be able to take a look at this PR?

It's my first time contributing, so I'd really appreciate any feedback in case I missed something. I'm happy to make adjustments if needed to get this merged. LMK!

Thanks a lot for your time!
Lean

@mattgperry
Copy link
Collaborator

Thanks for the PR! Next week is maintenance week so I’ll be taking a good look then!

@mattgperry
Copy link
Collaborator

Awesome contribution! Thanks for the PR

@mattgperry mattgperry merged commit cdbd047 into motiondivision:main Feb 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Reorder does not work as expected in a scrollable page

2 participants