From e8ad3d85e74864a54af43d928ff8551f02f3d443 Mon Sep 17 00:00:00 2001
From: Volker Krause <vkrause@kde.org>
Date: Sun, 22 Feb 2026 13:24:10 +0100
Subject: [PATCH] Use CMake's built-in functionality to enable -Werror (or
 equivalent)

Avoids having to manage this per compiler here, and gives users an easy
way to disable that passing --compile-no-warning-as-error to CMake.
---
 CMakeLists.txt | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c3c834d59..9c64f960d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -38,6 +38,7 @@ if (NIGIRI_LINT)
   include(cmake/clang-tidy.cmake)
 endif ()
 
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
   set(nigiri-compile-options
         -Weverything
@@ -66,20 +67,14 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
         -Wno-ctad-maybe-unsupported
         -Wno-nrvo
         -Wno-thread-safety-negative
-        -Wno-unused-private-field
-        -Werror)
+        -Wno-unused-private-field)
 elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang")
-  set(nigiri-compile-options -Wall -Wextra -Werror)
-elseif (MSVC)
-  set(nigiri-compile-options /WX)
-else ()
+  set(nigiri-compile-options -Wall -Wextra)
+elseif (NOT MSVC)
   set(nigiri-compile-options
         -Wall
         -Wextra
         -Wno-maybe-uninitialized)
-  if (NOT CMAKE_CROSSCOMPILING)
-    set(nigiri-compile-options ${nigiri-compile-options} -Werror)
-  endif ()
 endif ()