Add tests for multi-session Tracing domain support (first to trace wins) (facebook#55287)

Summary:

Changelog: [Internal]

Adds tests (and a doc comment) codifying the existing, correct behavior of the CDP `Tracing.start` command when there is already a tracing session in progress.

Reviewed By: hoxyq

Differential Revision: D90888857

Author: motiz88

packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.cpp

@@ -90,6 +90,8 @@ bool TracingAgent::handleRequest(const cdp::PreparsedRequest& req) {
     bool didNotHaveAlreadyRunningRecording = hostTargetController_.startTracing(
         tracing::Mode::CDP, std::move(enabledCategories));
     if (!didNotHaveAlreadyRunningRecording) {
+      // @cdp Tracing.start fails if there is a tracing session already running
+      // in the current target. This matches Chrome's behavior.
       frontendChannel_(
           cdp::jsonError(
               req.id,

packages/react-native/ReactCommon/jsinspector-modern/tests/TracingTest.cpp

@@ -113,4 +113,76 @@ TEST_F(TracingTest, EmitsScreenshotEventWhenScreenshotValuePassed) {
   EXPECT_THAT(allTraceEvents, Contains(AtJsonPtr("/name", "Screenshot")));
 }
 
+TEST_F(
+    TracingTest,
+    SecondSessionTracingStartIsRejectedWhileFirstSessionIsTracing) {
+  auto secondary = connectSecondary();
+  InSequence s;
+
+  // Session 1 starts tracing successfully
+  startTracing();
+
+  // Session 2 tries to start tracing - should get error
+  EXPECT_CALL(
+      secondary.fromPage(),
+      onMessage(JsonParsed(AllOf(
+          AtJsonPtr("/id", 2),
+          AtJsonPtr("/error/message", "Tracing has already been started")))));
+  secondary.toPage().sendMessage(R"({"id": 2, "method": "Tracing.start"})");
+
+  // Session 1 ends tracing normally
+  endTracingAndCollectEvents();
+
+  // Now Session 2 can start tracing
+  EXPECT_CALL(
+      secondary.fromPage(), onMessage(JsonEq(R"({"id": 3, "result": {}})")));
+  secondary.toPage().sendMessage(R"({"id": 3, "method": "Tracing.start"})");
+
+  // Clean up - end secondary's tracing
+  EXPECT_CALL(
+      secondary.fromPage(), onMessage(JsonEq(R"({"id": 4, "result": {}})")));
+  EXPECT_CALL(
+      secondary.fromPage(),
+      onMessage(JsonParsed(AtJsonPtr("/method", "Tracing.dataCollected"))))
+      .Times(AtLeast(1));
+  EXPECT_CALL(
+      secondary.fromPage(),
+      onMessage(JsonParsed(AtJsonPtr("/method", "Tracing.tracingComplete"))));
+  secondary.toPage().sendMessage(R"({"id": 4, "method": "Tracing.end"})");
+}
+
+TEST_F(TracingTest, CDPTracingPreemptsBackgroundTracing) {
+  InSequence s;
+
+  // Start background tracing directly
+  page_->startTracing(tracing::Mode::Background, {});
+
+  // CDP Tracing.start should preempt background (succeed, not fail)
+  startTracing();
+
+  // End tracing normally
+  endTracingAndCollectEvents();
+}
+
+TEST_F(TracingTest, BackgroundTracingIsRejectedWhileCDPTracingIsRunning) {
+  InSequence s;
+
+  // Start CDP tracing
+  startTracing();
+
+  // Background tracing should be rejected
+  bool started = page_->startTracing(tracing::Mode::Background, {});
+  EXPECT_FALSE(started);
+
+  // End CDP tracing
+  endTracingAndCollectEvents();
+
+  // Now background tracing should succeed
+  started = page_->startTracing(tracing::Mode::Background, {});
+  EXPECT_TRUE(started);
+
+  // Clean up
+  page_->stopTracing();
+}
+
 } // namespace facebook::react::jsinspector_modern