Add support for Rails 8.1 (#203)

Author: dankimio

app/controllers/motor/data_controller.rb

@@ -81,6 +81,7 @@ def execute
 
     def resource_params
       if params[:data].present?
+        # Allow all attributes through; dynamic model class limits what is actually persisted
         params.require(:data).permit!
       else
         {}

lib/motor/configs/sync_from_file.rb

@@ -23,7 +23,9 @@ def call(with_exception: false)
 
           next unless file_timestamp
 
-          FILE_TIMESTAMPS_STORE.fetch(file_timestamp.to_s) do
+          cache_key = file_timestamp.to_s
+
+          unless FILE_TIMESTAMPS_STORE.exist?(cache_key)
             Motor::Configs::SyncFromHash.call(
               YAML.safe_load(file.read, permitted_classes: [Time, Date])
             )

lib/motor/resources/fetch_configured_model.rb

@@ -114,36 +114,55 @@ def define_columns_hash(klass, config)
 
         columns_hash =
           columns.each_with_object({}) do |column, acc|
-            acc[column[:name]] =
-              if Rails.version.to_f >= 7.2
-                base_column.class.new(
-                  column[:name],
-                  nil,
-                  base_column.sql_type_metadata.class.new(
-                  ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: column[:column_type],
-                                                                        type: column[:column_type].to_sym))
-                )
-              else
-                ActiveRecord::ConnectionAdapters::Column.new(
-                  column[:name],
-                  nil,
-                  ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(sql_type: column[:column_type],
-                                                                        type: column[:column_type].to_sym)
-                )
-              end
+            acc[column[:name]] = synthesize_column(base_column, column[:name], column[:column_type])
           end
 
         klass.instance_variable_set(:@__motor_custom_sql_columns_hash, columns_hash)
 
         # rubocop:disable Naming/MemoizedInstanceVariableName
         klass.instance_eval do
+          # Expose custom_sql columns for reading/type-casting, but keep persistence
+          # behavior based only on real DB columns.
           def columns_hash
             @__motor__columns_hash ||= @__motor_custom_sql_columns_hash.merge(super)
           end
+
+          # Only real DB columns should be considered for persistence and strong params.
+          def column_names
+            connection.schema_cache.columns_hash(table_name).keys
+          end
+
+          # Same for the columns collection used by AR internals.
+          def columns
+            connection.schema_cache.columns(table_name)
+          end
         end
         # rubocop:enable Naming/MemoizedInstanceVariableName
       end
 
+      def synthesize_column(template_column, name, sql_type)
+        column = template_column.dup
+
+        generic_meta = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(
+          sql_type: sql_type,
+          type: sql_type.to_sym
+        )
+
+        adapter_meta = template_column.sql_type_metadata.class.new(generic_meta)
+
+        begin
+          cast_type = ActiveRecord::Type.lookup(sql_type.to_sym)
+        rescue StandardError
+          cast_type = ActiveRecord::Type.lookup(:string)
+        end
+
+        column.instance_variable_set(:@name, name)
+        column.instance_variable_set(:@sql_type_metadata, adapter_meta)
+        column.instance_variable_set(:@cast_type, cast_type)
+
+        column
+      end
+
       def define_column_reflections(klass, config)
         config.fetch(:columns, []).each do |column|
           reference = column[:reference]