Skip to content

Commit f2ea720

Browse files
authored
NO-JIRA: update Trivy version in CI and improve comments (red-hat-data-services#1328)
1 parent 2cd66bc commit f2ea720

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/build-notebooks-TEMPLATE.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
build:
3434
runs-on: ubuntu-24.04
3535
env:
36-
# Some pieces of code (image pulls for example) in podman consult TMPDIR or default to /var/tmp
36+
# Some pieces of code (image pulls, for example) in podman consult TMPDIR or default to /var/tmp
3737
TMPDIR: /home/runner/.local/share/containers/tmpdir
3838
# Use the rootful instance of podman for sharing images with cri-o
3939
# https://podman-desktop.io/blog/sharing-podman-images-with-kubernetes-cluster#introduction
@@ -43,7 +43,7 @@ jobs:
4343
IMAGE_REGISTRY: "ghcr.io/${{ github.repository }}/workbench-images"
4444
# GitHub image registry used for storing $(CONTAINER_ENGINE)'s cache
4545
CACHE: "ghcr.io/${{ github.repository }}/workbench-images/build-cache"
46-
TRIVY_VERSION: 0.57.1
46+
TRIVY_VERSION: 0.64.1
4747
TRIVY_VULNDB: "/home/runner/.local/share/containers/trivy_db"
4848
# Targets (and their folder) that should be scanned using FS instead of IMAGE scan due to resource constraints
4949
TRIVY_SCAN_FS_JSON: '{}'
@@ -664,7 +664,7 @@ jobs:
664664
# --ipc=host because Microsoft says so in Playwright docs
665665
# --net=host because testcontainers connects to the Reaper container's exposed port
666666
# we need to pass through the relevant environment variables
667-
# DEBUG configures nodejs debuggers, sets different verbosity as needed
667+
# DEBUG configures Node.js debuggers, sets different verbosity as needed
668668
# CI=true is set on every CI nowadays
669669
# PODMAN_SOCK should be mounted to /var/run/docker.sock, other likely mounting locations may not exist (mkdir -p)
670670
# TEST_TARGET is the workbench image the test will run

0 commit comments

Comments
 (0)