Skip to content

Commit 8decb19

Browse files
fix: skip Application::add rename rector for Console version compat shim
RenameMethodRector fires for Symfony\Component\Console\Application::add() whenever symfony/console >=7.4 is allowed by composer.json, but ValidateTranslationCommandTest::addCommandToApplication() intentionally calls add() as a runtime fallback for Symfony Console < 8.
1 parent c3aa232 commit 8decb19

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

rector.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
*/
1313

1414
use Rector\Config\RectorConfig;
15+
use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
1516
use Rector\Set\ValueObject\LevelSetList;
1617
use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
1718
use Rector\ValueObject\PhpVersion;
@@ -29,4 +30,11 @@
2930
->withRules([
3031
AddVoidReturnTypeWhereNoReturnRector::class,
3132
])
33+
->withSkip([
34+
// Application::add() is called intentionally as a runtime fallback for Symfony Console < 8,
35+
// see ValidateTranslationCommandTest::addCommandToApplication().
36+
RenameMethodRector::class => [
37+
__DIR__.'/tests/src/Command/ValidateTranslationCommandTest.php',
38+
],
39+
])
3240
;

0 commit comments

Comments
 (0)