[cleanup] Remove ModuleAccess and views (#17141)

## Description 

- Removed `ModuleAccess` and `views`. Without scripts, they are largely
useless

## Test plan 

- CI

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:

Author: tnowacki

crates/bytecode-verifier-tests/src/unit_tests/control_flow_tests.rs

@@ -4,7 +4,6 @@
 
 use crate::support::dummy_procedure_module;
 use move_binary_format::{
-    access::ModuleAccess,
     errors::PartialVMResult,
     file_format::{Bytecode, CompiledModule, FunctionDefinitionIndex, TableIndex},
 };

crates/invalid-mutations/src/bounds.rs

@@ -9,7 +9,6 @@ use move_binary_format::{
         ModuleHandleIndex, SignatureIndex, StructDefinitionIndex, StructHandleIndex, TableIndex,
     },
     internals::ModuleIndex,
-    views::{ModuleView, SignatureTokenView},
     IndexKind,
 };
 use move_core_types::vm_status::StatusCode;
@@ -324,19 +323,19 @@ impl ApplyOutOfBoundsContext {
 
     /// Returns the indexes of locals signatures that contain struct handles inside them.
     fn sig_structs(module: &CompiledModule) -> impl Iterator<Item = (SignatureIndex, usize)> + '_ {
-        let module_view = ModuleView::new(module);
-        module_view
+        module
             .signatures()
+            .iter()
             .enumerate()
             .flat_map(|(idx, signature)| {
                 let idx = SignatureIndex(idx as u16);
-                Self::find_struct_tokens(signature.tokens(), move |arg_idx| (idx, arg_idx))
+                Self::find_struct_tokens(&signature.0, move |arg_idx| (idx, arg_idx))
             })
     }
 
     #[inline]
     fn find_struct_tokens<'b, F, T>(
-        tokens: impl IntoIterator<Item = SignatureTokenView<'b, CompiledModule>> + 'b,
+        tokens: impl IntoIterator<Item = &'b SignatureToken> + 'b,
         map_fn: F,
     ) -> impl Iterator<Item = T> + 'b
     where
@@ -345,9 +344,7 @@ impl ApplyOutOfBoundsContext {
         tokens
             .into_iter()
             .enumerate()
-            .filter_map(move |(arg_idx, token)| {
-                struct_handle(token.signature_token()).map(|_| map_fn(arg_idx))
-            })
+            .filter_map(move |(arg_idx, token)| struct_handle(token).map(|_| map_fn(arg_idx)))
     }
 }
 

crates/move-binary-format/src/access.rs

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use crate::{
-    access::ModuleAccess,
     control_flow_graph::VMControlFlowGraph,
     file_format::{AbilitySet, CodeUnit, FunctionDefinitionIndex, FunctionHandle, Signature},
     CompiledModule,

crates/move-binary-format/src/binary_views.rs

@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use crate::{
-    access::ModuleAccess,
     errors::{
         bounds_error, offset_out_of_bounds as offset_out_of_bounds_error, verification_error,
         PartialVMError, PartialVMResult,