Skip to content

Commit 9ed6e46

Browse files
authored
[transactional-tests] Add upgrade-compatibility tests (#10917)
Adds compatibility tests to the transactional test runner to test different upgrade scenarios and compatibility checking around it. This also adds the ability to specify the upgrade policy when upgrading in the transactional test runner, and also relaxes compatibility requirements around constant pools in additive and dep_only modes (constants can be added/removed as long as they are not used, and added and used in additive mode).
1 parent a4879bb commit 9ed6e46

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

move-binary-format/src/compatibility.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,11 @@ impl InclusionCheck {
293293
}
294294

295295
// If we're checking exactness we make sure there's an inclusion, and that the size of all
296-
// of the tables are the exact same.
296+
// of the tables are the exact same except for constants.
297297
if (self == &Self::Equal)
298298
&& (old_module.structs.len() != new_module.structs.len()
299299
|| old_module.functions.len() != new_module.functions.len()
300-
|| old_module.friends.len() != new_module.friends.len()
301-
|| old_module.constants.len() != new_module.constants.len())
300+
|| old_module.friends.len() != new_module.friends.len())
302301
{
303302
return err;
304303
}

0 commit comments

Comments
 (0)