[debug] Disable printing on nodes (#10561)

## Description

Despite trying to disable printing using feature flags in #8795, it came
back because of the additive nature of `feature`s. This time, disable
debug printing on validators and full nodes for good, by controlling
their inclusion using a flag passed in during native function creation,
that controls whether to link against a silent version of the debug
print functions or not.

Unit tests, and other CLI usages of the VM typically link against the
unsilenced native functions, and the version used by validators is
silenced.

## Test Plan

Run all existing tests:

```
$ cargo simtest
$ env SUI_SKIP_SIMTESTS=1 cargo nextest run
```

Create a test move package with the following content:

```
module test::test {
    struct ImALittleTeapot has copy, drop, store {}
    public entry fun print() {
        std::debug::print(&ImALittleTeapot {});
    }

    #[test]
    fun test_printing() {
        print();
    }
}
```

And confirm that the following does print debug output

```
sui$ cargo build --bin sui --release
sui$ cargo build --bin sui-node --release
sui$ ./target/release/sui move test -p $PKG
```

While publishing to a local network and repeatedly calling `print` does
not pollute the validator or fullnode logs.

Author: amnn

documentation/examples/diem-framework/crates/cli/src/main.rs

@@ -36,6 +36,7 @@ fn main() -> Result<()> {
     )
     .into_iter()
     .chain(move_stdlib::natives::nursery_natives(
+        /* silent */ false,
         CORE_CODE_ADDRESS,
         // We may want to switch to a different gas schedule in the future, but for now,
         // the all-zero one should be enough.

move-stdlib/src/natives/debug.rs

@@ -26,6 +26,17 @@ pub struct PrintGasParameters {
     pub base_cost: InternalGas,
 }
 
+#[inline]
+fn native_print_nop(
+    gas_params: &PrintGasParameters,
+    ty_args: Vec<Type>,
+    args: VecDeque<Value>,
+) -> PartialVMResult<NativeResult> {
+    debug_assert!(ty_args.len() == 1);
+    debug_assert!(args.len() == 1);
+    Ok(NativeResult::ok(gas_params.base_cost, smallvec![]))
+}
+
 #[inline]
 fn native_print(
     gas_params: &PrintGasParameters,
@@ -68,14 +79,23 @@ fn native_print(
 }
 
 pub fn make_native_print(
+    silent: bool,
     gas_params: PrintGasParameters,
     move_std_addr: AccountAddress,
 ) -> NativeFunction {
-    Arc::new(
-        move |context, ty_args, args| -> PartialVMResult<NativeResult> {
-            native_print(&gas_params, context, ty_args, args, move_std_addr)
-        },
-    )
+    if silent {
+        Arc::new(
+            move |_context, ty_args, args| -> PartialVMResult<NativeResult> {
+                native_print_nop(&gas_params, ty_args, args)
+            },
+        )
+    } else {
+        Arc::new(
+            move |context, ty_args, args| -> PartialVMResult<NativeResult> {
+                native_print(&gas_params, context, ty_args, args, move_std_addr)
+            },
+        )
+    }
 }
 
 /***************************************************************************************************
@@ -88,6 +108,17 @@ pub struct PrintStackTraceGasParameters {
     pub base_cost: InternalGas,
 }
 
+#[inline]
+fn native_print_stack_trace_nop(
+    gas_params: &PrintStackTraceGasParameters,
+    ty_args: Vec<Type>,
+    args: VecDeque<Value>,
+) -> PartialVMResult<NativeResult> {
+    debug_assert!(ty_args.is_empty());
+    debug_assert!(args.is_empty());
+    Ok(NativeResult::ok(gas_params.base_cost, smallvec![]))
+}
+
 #[allow(unused_variables)]
 #[inline]
 fn native_print_stack_trace(
@@ -109,12 +140,23 @@ fn native_print_stack_trace(
     Ok(NativeResult::ok(gas_params.base_cost, smallvec![]))
 }
 
-pub fn make_native_print_stack_trace(gas_params: PrintStackTraceGasParameters) -> NativeFunction {
-    Arc::new(
-        move |context, ty_args, args| -> PartialVMResult<NativeResult> {
-            native_print_stack_trace(&gas_params, context, ty_args, args)
-        },
-    )
+pub fn make_native_print_stack_trace(
+    silent: bool,
+    gas_params: PrintStackTraceGasParameters,
+) -> NativeFunction {
+    if silent {
+        Arc::new(
+            move |_context, ty_args, args| -> PartialVMResult<NativeResult> {
+                native_print_stack_trace_nop(&gas_params, ty_args, args)
+            },
+        )
+    } else {
+        Arc::new(
+            move |context, ty_args, args| -> PartialVMResult<NativeResult> {
+                native_print_stack_trace(&gas_params, context, ty_args, args)
+            },
+        )
+    }
 }
 
 /***************************************************************************************************
@@ -127,14 +169,18 @@ pub struct GasParameters {
 }
 
 pub fn make_all(
+    silent: bool,
     gas_params: GasParameters,
     move_std_addr: AccountAddress,
 ) -> impl Iterator<Item = (String, NativeFunction)> {
     let natives = [
-        ("print", make_native_print(gas_params.print, move_std_addr)),
+        (
+            "print",
+            make_native_print(silent, gas_params.print, move_std_addr),
+        ),
         (
             "print_stack_trace",
-            make_native_print_stack_trace(gas_params.print_stack_trace),
+            make_native_print_stack_trace(silent, gas_params.print_stack_trace),
         ),
     ];
 

move-stdlib/src/natives/mod.rs

@@ -157,6 +157,7 @@ impl NurseryGasParameters {
 }
 
 pub fn nursery_natives(
+    silent: bool,
     move_std_addr: AccountAddress,
     gas_params: NurseryGasParameters,
 ) -> NativeFunctionTable {
@@ -171,7 +172,10 @@ pub fn nursery_natives(
     }
 
     add_natives!("event", event::make_all(gas_params.event));
-    add_natives!("debug", debug::make_all(gas_params.debug, move_std_addr));
+    add_natives!(
+        "debug",
+        debug::make_all(silent, gas_params.debug, move_std_addr)
+    );
 
     make_table_from_iter(move_std_addr, natives)
 }

move-stdlib/tests/move_unit_test.rs

@@ -20,6 +20,7 @@ fn run_tests_for_pkg(path_to_pkg: impl Into<String>, include_nursery_natives: bo
     );
     if include_nursery_natives {
         natives.extend(nursery_natives(
+            /* silent */ false,
             AccountAddress::from_hex_literal("0x1").unwrap(),
             NurseryGasParameters::zeros(),
         ))

tools/move-cli/src/main.rs

@@ -12,7 +12,11 @@ fn main() -> Result<()> {
     let addr = AccountAddress::from_hex_literal("0x1").unwrap();
     let natives = all_natives(addr, GasParameters::zeros())
         .into_iter()
-        .chain(nursery_natives(addr, NurseryGasParameters::zeros()))
+        .chain(nursery_natives(
+            /* silent */ false,
+            addr,
+            NurseryGasParameters::zeros(),
+        ))
         .collect();
 
     move_cli::move_cli(natives, cost_table, &error_descriptions)