remember internal/external mapping before pushing the new states

v4hn · v4hn · commit 2ab87a26d725 · 2021-04-13T14:13:32.000+02:00
Doesn't make a difference in single-threaded planning, but still better.
diff --git a/core/src/container.cpp b/core/src/container.cpp
@@ -197,9 +197,9 @@ void ContainerBasePrivate::copyState(Interface::iterator external, const Interfa
 
 	// create a clone of external state within target interface (child's starts() or ends())
 	auto internal = states_.insert(states_.end(), InterfaceState(*external));
-	target->add(*internal);
 	// and remember the mapping between them
 	internalToExternalMap().insert(std::make_pair(&*internal, &*external));
+	target->add(*internal);
 }
 
 void ContainerBasePrivate::liftSolution(const SolutionBasePtr& solution, const InterfaceState* internal_from,

Original file line number	Diff line number	Diff line change
`@@ -197,9 +197,9 @@ void ContainerBasePrivate::copyState(Interface::iterator external, const Interfa`
`197`	`197`
`198`	`198`	`// create a clone of external state within target interface (child's starts() or ends())`
`199`	`199`	`auto internal = states_.insert(states_.end(), InterfaceState(*external));`
`200`		`- target->add(*internal);`
`201`	`200`	`// and remember the mapping between them`
`202`	`201`	`internalToExternalMap().insert(std::make_pair(&internal, &external));`
	`202`	`+ target->add(*internal);`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`void ContainerBasePrivate::liftSolution(const SolutionBasePtr& solution, const InterfaceState* internal_from,`