clang-tidy: modernize-use-override

Author: v4hn

.clang-tidy

@@ -1,5 +1,6 @@
 ---
 Checks:          '-*,
+                  modernize-use-override,
                   modernize-use-using,
                   '
 HeaderFilterRegex: '.*/moveit/task_constructor/.*\.h'

capabilities/src/execute_task_solution_capability.h

@@ -55,7 +55,7 @@ class ExecuteTaskSolutionCapability : public MoveGroupCapability
 public:
 	ExecuteTaskSolutionCapability();
 
-	virtual void initialize();
+	void initialize() override;
 
 private:
 	bool constructMotionPlan(const moveit_task_constructor_msgs::Solution& solution,

core/include/moveit/task_constructor/stage.h

@@ -131,7 +131,7 @@ class InitStageException : public std::exception
 	/// check of existing errors
 	operator bool() const { return !errors_.empty(); }
 
-	virtual const char* what() const noexcept override;
+	const char* what() const noexcept override;
 
 private:
 	std::list<std::pair<const Stage*, const std::string>> errors_;

core/test/test_cost_queue.cpp

@@ -145,8 +145,8 @@ class CostOrderedTest : public ::testing::Test
 
 	cost_ordered<ValueType, CostType> queue;
 
-	void SetUp() {}
-	void TearDown() {}
+	void SetUp() override {}
+	void TearDown() override {}
 };
 using CostOrderedTestInt = CostOrderedTest<int, int>;
 

core/test/test_properties.cpp

@@ -110,7 +110,7 @@ TEST(Property, serialize) {
 class InitFromTest : public ::testing::Test
 {
 protected:
-	void SetUp() {
+	void SetUp() override {
 		master.declare<double>("double1", 1);
 		master.declare<double>("double2", 2);
 		master.declare<double>("double4", 4);

visualization/motion_planning_tasks/src/pluginlib_factory.h

@@ -75,12 +75,12 @@ class PluginlibFactory : public rviz::Factory
 	  : mime_type_(QString("application/%1/%2").arg(package, base_class_type)) {
 		class_loader_ = new pluginlib::ClassLoader<Type>(package.toStdString(), base_class_type.toStdString());
 	}
-	virtual ~PluginlibFactory() { delete class_loader_; }
+	~PluginlibFactory() override { delete class_loader_; }
 
 	/// retrieve mime type used for given factory
 	QString mimeType() const { return mime_type_; }
 
-	virtual QStringList getDeclaredClassIds() {
+	QStringList getDeclaredClassIds() override {
 		QStringList ids;
 		for (const auto& record : built_ins_)
 			ids.push_back(record.class_id_);
@@ -93,23 +93,23 @@ class PluginlibFactory : public rviz::Factory
 		return ids;
 	}
 
-	virtual QString getClassDescription(const QString& class_id) const {
+	QString getClassDescription(const QString& class_id) const override {
 		auto it = built_ins_.find(class_id);
 		if (it != built_ins_.end()) {
 			return it->description_;
 		}
 		return QString::fromStdString(class_loader_->getClassDescription(class_id.toStdString()));
 	}
 
-	virtual QString getClassName(const QString& class_id) const {
+	QString getClassName(const QString& class_id) const override {
 		auto it = built_ins_.find(class_id);
 		if (it != built_ins_.end()) {
 			return it->name_;
 		}
 		return QString::fromStdString(class_loader_->getName(class_id.toStdString()));
 	}
 
-	virtual QString getClassPackage(const QString& class_id) const {
+	QString getClassPackage(const QString& class_id) const override {
 		auto it = built_ins_.find(class_id);
 		if (it != built_ins_.end()) {
 			return it->package_;
@@ -125,7 +125,7 @@ class PluginlibFactory : public rviz::Factory
 		return QString::fromStdString(class_loader_->getPluginManifestPath(class_id.toStdString()));
 	}
 
-	virtual QIcon getIcon(const QString& class_id) const {
+	QIcon getIcon(const QString& class_id) const override {
 		QString package = getClassPackage(class_id);
 		QString class_name = getClassName(class_id);
 		QIcon icon = rviz::loadPixmap("package://" + package + "/icons/classes/" + class_name + ".svg");

visualization/motion_planning_tasks/src/remote_task_model.h

@@ -72,7 +72,7 @@ class RemoteTaskModel : public BaseTaskModel
 public:
 	RemoteTaskModel(const planning_scene::PlanningSceneConstPtr& scene, rviz::DisplayContext* display_context,
 	                QObject* parent = nullptr);
-	~RemoteTaskModel();
+	~RemoteTaskModel() override;
 
 	void setSolutionClient(ros::ServiceClient* client);
 

visualization/motion_planning_tasks/src/task_list_model.h

@@ -143,7 +143,7 @@ class TaskListModel : public utils::FlatMergeProxyModel
 
 public:
 	TaskListModel(QObject* parent = nullptr);
-	~TaskListModel();
+	~TaskListModel() override;
 
 	void setScene(const planning_scene::PlanningSceneConstPtr& scene);
 	void setDisplayContext(rviz::DisplayContext* display_context);

visualization/motion_planning_tasks/src/task_panel.h

@@ -80,7 +80,7 @@ class TaskPanel : public rviz::Panel
 
 public:
 	TaskPanel(QWidget* parent = 0);
-	~TaskPanel();
+	~TaskPanel() override;
 
 	/// add a new sub panel widget
 	void addSubPanel(SubPanel* w, const QString& title, const QIcon& icon);
@@ -127,7 +127,7 @@ class TaskView : public SubPanel
 
 public:
 	TaskView(TaskPanel* parent, rviz::Property* root);
-	~TaskView();
+	~TaskView() override;
 
 	void save(rviz::Config config) override;
 	void load(const rviz::Config& config) override;
@@ -152,7 +152,7 @@ class GlobalSettingsWidget : public SubPanel
 
 public:
 	GlobalSettingsWidget(TaskPanel* parent, rviz::Property* root);
-	~GlobalSettingsWidget();
+	~GlobalSettingsWidget() override;
 
 	void save(rviz::Config config) override;
 	void load(const rviz::Config& config) override;

visualization/motion_planning_tasks/test/test_merge_models.cpp

@@ -195,7 +195,7 @@ class FlatMergeModelRemove : public ::testing::Test
 {
 protected:
 	FlatMergeProxyModel flat;
-	void SetUp() {
+	void SetUp() override {
 		flat.insertModel(createStandardModel(&flat, 1, 3, 2));
 		flat.insertModel(createStandardModel(&flat, 2, 3, 2));
 		flat.insertModel(createStandardModel(&flat, 3, 3, 2));