rely on post-noetic pybind11_catkin (#733)

v4hn · web-flow · commit 4b9c872818c9 · 2025-12-12T23:49:09.000+01:00
ros-o's pybind11_catkin bundles a sufficient pybind11
and ensures python_add_library is available also with ros-o catkin,
where the implicit `find_package(Python COMPONENTS Interpreter)`
does not provide it by default anymore.
diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt
@@ -14,6 +14,7 @@ find_package(catkin REQUIRED COMPONENTS
 	roscpp
 	visualization_msgs
 	rviz_marker_tools
+	pybind11_catkin
 	py_binding_tools
 )
 
diff --git a/core/package.xml b/core/package.xml
@@ -17,6 +17,7 @@
 
 	<build_depend>roscpp</build_depend>
 	<build_depend>roslint</build_depend>
+	<build_depend>pybind11_catkin</build_depend>
 	<exec_depend>roscpp</exec_depend>
 
 	<depend>fmt</depend>
diff --git a/core/python/CMakeLists.txt b/core/python/CMakeLists.txt
@@ -1,7 +1,3 @@
-# pybind11 must use the ROS python version
-set(PYBIND11_PYTHON_VERSION ${PYTHON_VERSION})
-find_package(pybind11 3.0 REQUIRED)
-
 # C++ wrapper code
 add_subdirectory(bindings)
 
diff --git a/core/python/bindings/CMakeLists.txt b/core/python/bindings/CMakeLists.txt
@@ -11,7 +11,7 @@ target_link_libraries(${PROJECT_NAME}_python_tools PUBLIC pybind11::opt_size)
 #catkin_lint: ignore undefined_target
 
 # moveit.task_constructor
-pybind11_add_module(pymoveit_mtc
+pybind_add_module(pymoveit_mtc
 	src/solvers.cpp
 	src/core.cpp
 	src/stages.cpp

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ find_package(catkin REQUIRED COMPONENTS`
`14`	`14`	`roscpp`
`15`	`15`	`visualization_msgs`
`16`	`16`	`rviz_marker_tools`
	`17`	`+ pybind11_catkin`
`17`	`18`	`py_binding_tools`
`18`	`19`	`)`
`19`	`20`