clang-tidy: modernize-use-nullptr

Author: v4hn

.clang-tidy

@@ -1,5 +1,6 @@
 ---
 Checks:          '-*,
+                  modernize-use-nullptr,
                   modernize-use-override,
                   modernize-use-using,
                   modernize-loop-convert,

core/include/moveit/task_constructor/storage.h

@@ -206,14 +206,14 @@ class SolutionBase
 
 	inline void setStartState(const InterfaceState& state) {
 		// only allow setting once (by Stage)
-		assert(start_ == NULL || start_ == &state);
+		assert(start_ == nullptr || start_ == &state);
 		start_ = &state;
 		const_cast<InterfaceState&>(state).addOutgoing(this);
 	}
 
 	inline void setEndState(const InterfaceState& state) {
 		// only allow setting once (by Stage)
-		assert(end_ == NULL || end_ == &state);
+		assert(end_ == nullptr || end_ == &state);
 		end_ = &state;
 		const_cast<InterfaceState&>(state).addIncoming(this);
 	}

visualization/motion_planning_tasks/src/job_queue.h

@@ -55,7 +55,7 @@ class JobQueue : public QObject
 	boost::condition_variable idle_condition_;
 
 public:
-	explicit JobQueue(QObject* parent = 0);
+	explicit JobQueue(QObject* parent = nullptr);
 	void addJob(const std::function<void()>& job);
 	void clear();
 	size_t numPending();

visualization/motion_planning_tasks/src/pluginlib_factory.h

@@ -163,11 +163,11 @@ class PluginlibFactory : public rviz::Factory
 	 *
 	 * If makeRaw() returns NULL and error_return is not NULL, *error_return will be set.
 	 * On success, *error_return will not be changed. */
-	virtual Type* makeRaw(const QString& class_id, QString* error_return = NULL) {
+	virtual Type* makeRaw(const QString& class_id, QString* error_return = nullptr) {
 		typename QHash<QString, BuiltInClassRecord>::const_iterator iter = built_ins_.find(class_id);
 		if (iter != built_ins_.end()) {
 			Type* instance = iter->factory_function_();
-			if (instance == NULL && error_return != NULL) {
+			if (instance == nullptr && error_return != nullptr) {
 				*error_return = "Factory function for built-in class '" + class_id + "' returned NULL.";
 			}
 			return instance;
@@ -180,7 +180,7 @@ class PluginlibFactory : public rviz::Factory
 			if (error_return) {
 				*error_return = QString::fromStdString(ex.what());
 			}
-			return NULL;
+			return nullptr;
 		}
 	}
 

visualization/motion_planning_tasks/src/task_panel.h

@@ -79,7 +79,7 @@ class TaskPanel : public rviz::Panel
 	TaskPanelPrivate* d_ptr;
 
 public:
-	TaskPanel(QWidget* parent = 0);
+	TaskPanel(QWidget* parent = nullptr);
 	~TaskPanel() override;
 
 	/// add a new sub panel widget

visualization/visualization_tools/include/moveit/visualization_tools/task_solution_panel.h

@@ -52,7 +52,7 @@ class TaskSolutionPanel : public rviz::Panel
 	Q_OBJECT
 
 public:
-	TaskSolutionPanel(QWidget* parent = 0);
+	TaskSolutionPanel(QWidget* parent = nullptr);
 
 	~TaskSolutionPanel() override;
 

visualization/visualization_tools/src/task_solution_visualization.cpp

@@ -267,7 +267,7 @@ void TaskSolutionVisualization::changedTrail() {
 	for (std::size_t i = 0; i < trail_.size(); i++) {
 		int waypoint_i = std::min(i * stepsize, t->getWayPointCount() - 1);  // limit to last trajectory point
 		rviz::Robot* r =
-		    new rviz::Robot(trail_scene_node_, context_, "Trail Robot " + boost::lexical_cast<std::string>(i), NULL);
+		    new rviz::Robot(trail_scene_node_, context_, "Trail Robot " + boost::lexical_cast<std::string>(i), nullptr);
 		r->load(*scene_->getRobotModel()->getURDF());
 		r->setVisualVisible(robot_visual_enabled_property_->getBool());
 		r->setCollisionVisible(robot_collision_enabled_property_->getBool());