Fix warning: control reaches end of non-void function

rhaschke · rhaschke · commit 5dacc85ff98b · 2021-06-10T07:35:09.000+02:00
diff --git a/visualization/motion_planning_tasks/properties/property_from_yaml.cpp b/visualization/motion_planning_tasks/properties/property_from_yaml.cpp
@@ -151,9 +151,8 @@ rviz::Property* Parser::process(const yaml_event_t& event, const QString& name,
 		case YAML_SCALAR_EVENT:
 			return createScalar(name, description, byteArray(event), old);
 		default:
-			break;
+			throw std::runtime_error("Unhandled YAML event");
 	}
-	assert(false);  // should not be reached
 }
 
 // Try to set numeric or arbitrary scalar value from YAML node. Needs to match old's type.

Original file line number	Diff line number	Diff line change
`@@ -151,9 +151,8 @@ rviz::Property* Parser::process(const yaml_event_t& event, const QString& name,`
`151`	`151`	`case YAML_SCALAR_EVENT:`
`152`	`152`	`return createScalar(name, description, byteArray(event), old);`
`153`	`153`	`default:`
`154`		`- break;`
	`154`	`+ throw std::runtime_error("Unhandled YAML event");`
`155`	`155`	`}`
`156`		`- assert(false); // should not be reached`
`157`	`156`	`}`
`158`	`157`
`159`	`158`	`// Try to set numeric or arbitrary scalar value from YAML node. Needs to match old's type.`