resolve clang warnings & suggestions

Author: v4hn

core/include/moveit/task_constructor/stage.h

@@ -209,7 +209,7 @@ class Stage
 	/// overload: const char* values are stored as std::string
 	inline void setProperty(const std::string& name, const char* value) { setProperty(name, std::string(value)); }
 	/// analyze source of error and report accordingly
-	void reportPropertyError(const Property::error& e);
+	[[noreturn]] void reportPropertyError(const Property::error& e);
 	double getTotalComputeTime() const;
 
 protected:

core/src/container.cpp

@@ -366,7 +366,8 @@ void SerialContainer::onNewSolution(const SolutionBase& current) {
 	solution.reserve(children.size());
 	for (auto& in : incoming.solutions) {
 		for (auto& out : outgoing.solutions) {
-			InterfaceState::Priority prio(in.first.size() + 1 + out.first.size(), in.second + current.cost() + out.second);
+			InterfaceState::Priority prio(static_cast<unsigned int>(in.first.size() + 1 + out.first.size()),
+			                              in.second + current.cost() + out.second);
 			// found a complete solution path connecting start to end?
 			if (prio.depth() == children.size()) {
 				if (std::isinf(prio.cost()))

core/src/stage.cpp

@@ -69,7 +69,7 @@ std::ostream& operator<<(std::ostream& os, const InitStageException& e) {
 }
 
 StagePrivate::StagePrivate(Stage* me, const std::string& name)
-  : me_(me), name_(name), parent_(nullptr), total_compute_time_{}, introspection_(nullptr) {}
+  : me_(me), name_(name), total_compute_time_{}, parent_(nullptr), introspection_(nullptr) {}
 
 InterfaceFlags StagePrivate::interfaceFlags() const {
 	InterfaceFlags f;
@@ -318,7 +318,7 @@ void StagePrivate::composePropertyErrorMsg(const std::string& property_name, std
 			os << ", inherits from parent";
 		if (p.initsFrom(Stage::INTERFACE))
 			os << ", initializes from interface";
-	} catch (const Property::undeclared& e) {
+	} catch (const Property::undeclared&) {
 		os << "undeclared";
 	}
 	if (parent()->parent())

visualization/motion_planning_tasks/src/task_display.h

@@ -76,16 +76,16 @@ class TaskDisplay : public rviz::Display
 
 public:
 	TaskDisplay();
-	~TaskDisplay();
+	~TaskDisplay() override;
 
 	void loadRobotModel();
 
 	void update(float wall_dt, float ros_dt) override;
 	void reset() override;
-	void save(rviz::Config config) const;
-	void load(const rviz::Config& config);
+	void save(rviz::Config config) const override;
+	void load(const rviz::Config& config) override;
 
-	void setName(const QString& name);
+	void setName(const QString& name) override;
 	void setSolutionStatus(bool ok);
 
 	TaskListModel& getTaskListModel() { return *task_list_model_; }

visualization/motion_planning_tasks/src/task_panel.cpp

@@ -192,7 +192,7 @@ void setExpanded(QTreeView* view, const QModelIndex& index, bool expand, int dep
 	// recursively expand all children
 	if (depth != 0) {
 		for (int row = 0, rows = index.model()->rowCount(index); row < rows; ++row)
-			setExpanded(view, index.child(row, 0), expand, depth - 1);
+			setExpanded(view, index.model()->index(row, 0, index), expand, depth - 1);
 	}
 
 	view->setExpanded(index, expand);
@@ -212,7 +212,7 @@ TaskViewPrivate::TaskViewPrivate(TaskView* q_ptr) : q_ptr(q_ptr), exec_action_cl
 		                 if (parent.isValid() && !parent.parent().isValid()) {  // top-level task items inserted
 			                 int expand = this->q_ptr->initial_task_expand->getOptionInt();
 			                 for (int row = first; row <= last; ++row) {
-				                 QModelIndex child = parent.child(row, 0);
+				                 QModelIndex child = parent.model()->index(row, 0, parent);
 				                 if (expand != TaskView::EXPAND_NONE) {
 					                 // recursively expand all inserted items
 					                 setExpanded(tasks_view, child, true);
@@ -352,7 +352,7 @@ void TaskView::load(const rviz::Config& config) {
 
 	QTreeView* view = d_ptr->solutions_view;
 	rviz::Config group = config.mapGetChild("solution_sorting");
-	int order;
+	int order = 0;
 	if (group.mapGetInt("column", &column) && group.mapGetInt("order", &order))
 		view->sortByColumn(column, static_cast<Qt::SortOrder>(order));
 }