minor cleanup, fixing warnings, improving comments

Author: rhaschke

core/include/moveit/task_constructor/stage_p.h

@@ -164,7 +164,7 @@ class StagePrivate
 	std::string name_;
 	PropertyMap properties_;
 
-	// the stage's pull interfaces, created as required
+	// pull interfaces, created by the stage as required
 	InterfacePtr starts_;
 	InterfacePtr ends_;
 
@@ -184,6 +184,8 @@ class StagePrivate
 	ContainerBase* parent_;  // owning parent
 	container_type::iterator it_;  // iterator into parent's children_ list referring to this
 
+	// push interfaces, assigned by the parent container
+	// linking to previous/next sibling's pull interfaces
 	InterfaceWeakPtr prev_ends_;  // interface to be used for sendBackward()
 	InterfaceWeakPtr next_starts_;  // interface to be used for sendForward()
 

core/src/stage.cpp

@@ -563,7 +563,7 @@ PropagatingForwardPrivate::PropagatingForwardPrivate(PropagatingForward* me, con
 PropagatingForward::PropagatingForward(const std::string& name)
   : PropagatingEitherWay(new PropagatingForwardPrivate(this, name)) {}
 
-void PropagatingForward::computeBackward(const InterfaceState& to) {
+void PropagatingForward::computeBackward(const InterfaceState& /* to */) {
 	assert(false);  // This should never be called
 }
 
@@ -576,7 +576,7 @@ PropagatingBackwardPrivate::PropagatingBackwardPrivate(PropagatingBackward* me,
 PropagatingBackward::PropagatingBackward(const std::string& name)
   : PropagatingEitherWay(new PropagatingBackwardPrivate(this, name)) {}
 
-void PropagatingBackward::computeForward(const InterfaceState& from) {
+void PropagatingBackward::computeForward(const InterfaceState& /* from */) {
 	assert(false);  // This should never be called
 }
 

visualization/motion_planning_tasks/src/task_list_model.cpp

@@ -125,8 +125,6 @@ QVariant BaseTaskModel::flowIcon(moveit::task_constructor::InterfaceFlags f) {
 	static const QIcon FORWARD_ICON = icons::FORWARD.icon();
 	static const QIcon BACKWARD_ICON = icons::BACKWARD.icon();
 	static const QIcon GENERATE_ICON = icons::GENERATE.icon();
-	// might be needed for graphical setup of tasks
-	//	static const QIcon BOTHWAY_ICON = icons::BOTHWAY.icon();
 
 	if (f == InterfaceFlags(CONNECT))
 		return CONNECT_ICON;