Optimize setStatus(): only escalate to parent interface at boundaries of a partial solution

rhaschke · v4hn · commit 9da3a8055ea9 · 2021-09-20T23:07:00.000+02:00
In all other cases internalToExternalMap().find(s) will fail anyway.
diff --git a/core/src/container.cpp b/core/src/container.cpp
@@ -162,7 +162,7 @@ void ContainerBasePrivate::setStatus(const InterfaceState* s, InterfaceState::St
 	}
 
 	// if possible (i.e. if state s has an external counterpart), escalate setStatus to external interface
-	if (parent()) {
+	if (parent() && trajectories<dir>(*s).empty()) {
 		auto external{ internalToExternalMap().find(s) };
 		if (external != internalToExternalMap().end()) {  // do we have an external state?
 			// only escalate if there is no other *enabled* internal state connected to the same external one

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ void ContainerBasePrivate::setStatus(const InterfaceState* s, InterfaceState::St`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`// if possible (i.e. if state s has an external counterpart), escalate setStatus to external interface`
`165`		`- if (parent()) {`
	`165`	`+ if (parent() && trajectories<dir>(*s).empty()) {`
`166`	`166`	`auto external{ internalToExternalMap().find(s) };`
`167`	`167`	`if (external != internalToExternalMap().end()) { // do we have an external state?`
`168`	`168`	`// only escalate if there is no other enabled internal state connected to the same external one`