Skip to content

Commit cc86dd8

Browse files
committed
rename Task::erase -> eraseTaskCallback
`erase` is too general for a container class, when it's not actually about erasing children or the container itself.
1 parent c046ec6 commit cc86dd8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

core/include/moveit/task_constructor/task.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ class Task : protected WrapperBase
105105
/// add function to be called after each top-level iteration
106106
TaskCallbackList::const_iterator addTaskCallback(TaskCallback&& cb);
107107
/// remove function callback
108-
void erase(TaskCallbackList::const_iterator which);
108+
void eraseTaskCallback(TaskCallbackList::const_iterator which);
109109

110110
/// expose SolutionCallback API
111111
using WrapperBase::SolutionCallback;

core/src/task.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ Task::TaskCallbackList::const_iterator Task::addTaskCallback(TaskCallback&& cb)
235235
return --(impl->task_cbs_.cend());
236236
}
237237

238-
void Task::erase(TaskCallbackList::const_iterator which) {
238+
void Task::eraseTaskCallback(TaskCallbackList::const_iterator which) {
239239
pimpl()->task_cbs_.erase(which);
240240
}
241241

0 commit comments

Comments
 (0)