feat: make is_core_resource_address always return false

Author: andygolay

aptos-move/framework/aptos-framework/sources/configs/version.move

@@ -92,6 +92,7 @@ module aptos_framework::version {
     }
 
     #[test(aptos_framework = @aptos_framework, core_resources = @core_resources)]
+    #[expected_failure(abort_code = 327681, location = system_addresses)]
     public entry fun test_set_version_core_resources(
         aptos_framework: signer,
         core_resources: signer,

aptos-move/framework/aptos-framework/sources/system_addresses.move

@@ -20,7 +20,7 @@ module aptos_framework::system_addresses {
     }
 
     public fun is_core_resource_address(addr: address): bool {
-        addr == @core_resources
+        false
     }
 
     public fun assert_aptos_framework(account: &signer) {
@@ -79,4 +79,11 @@ module aptos_framework::system_addresses {
     public fun is_reserved_address(addr: address): bool {
         is_aptos_framework_address(addr) || is_vm_address(addr)
     }
+
+    #[test(aptos_framework = @aptos_framework, core_resources = @0xA550C18)]
+    #[expected_failure(abort_code = 327681, location = Self)]
+    public entry fun test_core_resource_check_fails(core_resources: signer) {
+        // This should now abort due to is_core_resource_address always returning false
+        assert_core_resource_address(signer::address_of(&core_resources));
+    }
 }