Deprecate Governed Gas Pool for `transaction_fee::collect_fee`

[0xmovses]

Description

As part of the framework upgrade described in L1 Migration we want to deprecate the Governed Gas Pool as part of the framework and instead use transation_fee::collect_fee(). This was done here (along with the old native and atomic bridge modules) https://github.com/movementlabsxyz/aptos-core/pull/156/files.

We need to keep the invariant of our network the constant supply of 10 Billion MOVE tokens. This is one differentiating characteristic with Aptos where they do not have a fixed supply.

The Governed Gas Pool was designed as part of the Biartiz Model (see the relevant MIP if you want more info) and was implemented in this PR #114

Note specifically how the previous burn call is replaced by a deposit to the GGP module here: https://github.com/movementlabsxyz/aptos-core/pull/114/files#r2164296427

Instead we want to call the framework function transcation_fee::collect_fee() for this the feature needs to be enabled

aptos-core/aptos-move/framework/aptos-framework/sources/transaction_fee.move

Line 119 in 31d9876

fun is_fees_collection_enabled(): bool {

1. Make the change in the framework to use the method instead of call governed gas pool.

2. Enable the Feature using the release testing method, use this PR as a means to test it locally: feat: pre-l1-merge framework upgrade + e2e tests movement#1212 and issue the upgrade for the new framework version.

3. Write an e2e test that tests that fees are being collected in the way we expect them to, similar to the GGP test e2e test coverage https://github.com/movementlabsxyz/movement/pull/998/files

Success Criteria

Have the new test in the movement repo which enables the feature, issues the upgrade and checks that fees are being accrued as we expect them to be

[nicolaslpf]

hey @0xIcarus one question after transaction_fee::collect_fee is implemented it will emit extra events in addition to "0x1::transaction_fee::FeeStatement". ?
Context : We currently emit 2 extra withdraw and deposit events using 0x1::governed_gas_pool::GovernedGasPool which is causing some inconsistencies in Coin and Fa activities processed by the indexer. So need to know if deprecating it for transaction_fee::collect_fee will remove those extra events and we will only have the "0x1::transaction_fee::FeeStatement" in the tx.

[0xmovses]

Let's add some event assertions in the e2e test for collect_fee()

[sebtomba]

I assume transaction_fee::initialize_fee_collection_and_distribution() will be called with 0% burn_percentage for our L1 network?

[sebtomba]

Caution

There are still two edge cases where coins would get burned:

1. The VM has produced the block.
2. The proposer is not set in the block prologue.

See https://github.com/movementlabsxyz/aptos-core/blob/movement/aptos-move/framework/aptos-framework/sources/transaction_fee.move#L191

[sebtomba]

The current balance of the governed gas pool on mainnet is 2172478779470 coins.

To get the current balance, use the aptos or movement CLI:

aptos move view \
        --function-id 0x1::governed_gas_pool::get_balance \
        --type-args 0x1::aptos_coin::AptosCoin \
        --url https://mainnet.movementnetwork.xyz/v1

Or just use the block explorer:
https://explorer.movementlabs.xyz/account/0x9bb809cb154a393546da38ff08bc927679e77ecdb59dab49029315b54644e40e?network=mainnet

[0xmovses]

Ahh you need to query the resource account generated by the governed gas pool

0x9bb809cb154a393546da38ff08bc927679e77ecdb59dab49029315b54644e40e

that addy is the governed gas pool but it generates it's own resource account for MOVE. See the implementation

aptos-core/aptos-move/framework/aptos-framework/sources/governed_gas_pool.move

Line 38 in 31d9876

fun create_resource_account_seed(

cc @areshand @nicolaslpf

[0xmovses]

And

aptos-core/aptos-move/framework/aptos-framework/sources/governed_gas_pool.move

Line 66 in 31d9876

let (governed_gas_pool_signer, governed_gas_pool_signer_cap) = account::create_resource_account(aptos_framework, seed);