Deprecate usage of governed gas pool #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmovses
requested changes
Jul 31, 2025
There was a problem hiding this comment.
This looks good. I have one move unit failing test movement move test. I know there were many more failing and you've solved a lot of them. Almost there.
Failures in 0x1::aptos_governance:
┌── test_stake_pool_can_vote_before_and_after_partial_governance_voting_enabled ──────
│ error[E11001]: test failure
│ ┌─ /Users/movses/mvmt/mvmt-aptos-core/aptos-move/framework/aptos-framework/sources/aptos_governance.move:752:13
│ │
│ 750 │ fun assert_voting_initialization() {
│ │ ---------------------------- In this function in 0x1::aptos_governance
│ 751 │ if (features::partial_governance_voting_enabled()) {
│ 752 │ assert!(exists<VotingRecordsV2>(@aptos_framework), error::invalid_state(EPARTIAL_VOTING_NOT_INITIALIZED));
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test was not expected to error, but it aborted with code 196621 originating in the module 0000000000000000000000000000000000000000000000000000000000000001::aptos_governance rooted here
│
│
│ stack trace
│ aptos_governance::get_remaining_voting_power(/Users/movses/mvmt/mvmt-aptos-core/aptos-move/framework/aptos-framework/sources/aptos_governance.move:312)
│ aptos_governance::test_stake_pool_can_vote_before_and_after_partial_governance_voting_enabled(/Users/movses/mvmt/mvmt-aptos-core/aptos-move/framework/aptos-framework/sources/aptos_governance.move:1162)
│
└──────────────────
Test result: FAILED. Total tests: 499; passed: 498; failed: 1
{
"Error": "Move unit tests failed"
}
Furthermore, we should deprecate the GGP feature using the upstream procedure. See for example this _DEPRECATED... feature from the upstream repo: https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-release-builder/src/components/feature_flags.rs#L235
Instead of removing the feature from the enum, follow the example. Hopefully there are not too many gotyas.
Also make sure to run all the rust e2e tests that utilise the MoveHarness cargo test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR deprecates usage of governed gas pool and sets up
stake.movewith the right prerequisite function calls to enable votingCOLLECT_AND_DISTRIBUTE_GAS_FEESfeature flag through using the release testing methodType of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist