Revert "refactor(e2e): move e2e criterion GlobalFeatureCheck to checks/migrator"

Author: l-monninger

Cargo.lock

@@ -191,9 +191,6 @@ mtma-node-test-global-storage-not-empty-criterion = { path = "checks/node/citeri
 
 ### migrator
 mtma-migrator-test-types = { path = "checks/migrator/util/types" }
-mtma-migrator-test-empty-criterion = { path = "checks/migrator/citeria/empty" }
-mtma-migrator-test-matching-feature-flags-criterion = { path = "checks/migrator/citeria/matching-feature-flags" }
-mtma-migrator-test-transacting-criterion = { path = "checks/migrator/citeria/transacting" }
 mtma-migrator-test-accounts-equal-criterion = { path = "checks/migrator/citeria/accounts-equal" }
 mtma-migrator-test-balances-equal-criterion = { path = "checks/migrator/citeria/balances-equal" }
 

Cargo.toml

@@ -13,9 +13,6 @@ mtma-types = { workspace = true }
 mtma-migrator-types = { workspace = true }
 mtma-migrator-test-types = { workspace = true }
 anyhow = { workspace = true }
-mtma-migrator-test-matching-feature-flags-criterion = { workspace = true }
-mtma-migrator-test-transacting-criterion = { workspace = true }
-mtma-migrator-test-empty-criterion = { workspace = true }
 mtma-node-replay-core = { workspace = true }
 mtma-node-test-global-storage-injective-criterion = { workspace = true }
 mtma-node-test-global-storage-includes-criterion = { workspace = true }
@@ -28,7 +25,6 @@ chrono = { workspace = true }
 rand = { workspace = true }
 kestrel = { workspace = true }
 mtma-node-test-types = { workspace = true }
-aptos-sdk = { workspace = true }
 
 [dev-dependencies]
 tracing-test = { workspace = true }

checks/migrator/checks/sketchpad/Cargo.toml

@@ -1,3 +1 @@
-pub mod matching_feature_flags;
-pub mod transacting;
 pub mod accounts_equal;

checks/migrator/checks/sketchpad/src/lib.rs

@@ -9,7 +9,8 @@ publish = { workspace = true }
 rust-version = { workspace = true }
 
 [dependencies]
-mtma-migrator-test-types = { workspace = true }
+mtma-node-test-types = { workspace = true }
+
 
 [lints]
 workspace = true

checks/migrator/checks/sketchpad/src/matching_feature_flags.rs

@@ -1,5 +1,5 @@
-use mtma_migrator_test_types::criterion::{
-	Criterion, CriterionError, Criterionish, MovementAptosMigrator, MovementMigrator,
+use mtma_node_test_types::criterion::{
+	Criterion, CriterionError, Criterionish, MovementAptosNode, MovementNode,
 };
 
 pub struct Empty;
@@ -15,10 +15,10 @@ impl Empty {
 }
 
 impl Criterionish for Empty {
-	async fn satisfies(
+	fn satisfies(
 		&self,
-		_movement_migrator: &MovementMigrator,
-		_movement_aptos_migrator: &MovementAptosMigrator,
+		_movement_executor: &MovementNode,
+		_movement_aptos_executor: &MovementAptosNode,
 	) -> Result<(), CriterionError> {
 		Ok(())
 	}