feature(e2e): split out matching-feature-flags check into a crate

sebtomba · sebtomba · commit b207ee166919 · 2025-06-09T13:53:46.000+02:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/checks/migrator/checks/balances-equal/Cargo.toml b/checks/migrator/checks/balances-equal/Cargo.toml
@@ -9,20 +9,12 @@ publish = { workspace = true }
 rust-version = { workspace = true }
 
 [dependencies]
-mtma-types = { workspace = true }
 mtma-migrator-types = { workspace = true }
 mtma-migrator-test-types = { workspace = true }
 anyhow = { workspace = true }
-mtma-node-replay-core = { workspace = true }
-mtma-node-test-global-storage-injective-criterion = { workspace = true }
-mtma-node-test-global-storage-includes-criterion = { workspace = true }
-mtma-node-test-global-storage-not-empty-criterion = { workspace = true }
 mtma-migrator-test-balances-equal-criterion = { workspace = true }
-mtma-node-preludes = { workspace = true }
 mtma-node-null-core = { workspace = true }
 tokio = { workspace = true }
-chrono = { workspace = true }
-rand = { workspace = true }
 kestrel = { workspace = true }
 mtma-node-test-types = { workspace = true }
 
diff --git a/checks/migrator/checks/balances-equal/src/balances_equal.rs b/checks/migrator/checks/balances-equal/src/balances_equal.rs
@@ -68,6 +68,6 @@ pub mod test {
 		// exit the test is fine when you only have one test per crate because when cargo test is run across a workspace, it actually multi-processes the tests by crate
 		std::process::exit(0);
 
-		Ok(())
+		// Ok(())
 	}
 }
diff --git a/checks/migrator/checks/matching-feature-flags/Cargo.toml b/checks/migrator/checks/matching-feature-flags/Cargo.toml
@@ -0,0 +1,26 @@
+[package]
+name = "mtma-migrator-matching-feature-flags"
+version = { workspace = true }
+edition = { workspace = true }
+license = { workspace = true }
+authors = { workspace = true }
+homepage = { workspace = true }
+publish = { workspace = true }
+rust-version = { workspace = true }
+
+[dependencies]
+mtma-migrator-types = { workspace = true }
+mtma-migrator-test-types = { workspace = true }
+anyhow = { workspace = true }
+mtma-migrator-test-matching-feature-flags-criterion = { workspace = true }
+mtma-node-null-core = { workspace = true }
+tokio = { workspace = true }
+kestrel = { workspace = true }
+mtma-node-test-types = { workspace = true }
+
+[dev-dependencies]
+tracing-test = { workspace = true }
+tracing = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/checks/migrator/checks/matching-feature-flags/README.md b/checks/migrator/checks/matching-feature-flags/README.md
@@ -0,0 +1,2 @@
+# Migration Executor Checks Sketchpad
+A sketchpad for playing around with checks on the testpad. 
diff --git a/checks/migrator/checks/matching-feature-flags/src/lib.rs b/checks/migrator/checks/matching-feature-flags/src/lib.rs
@@ -0,0 +1 @@
+pub mod matching_feature_flags;
diff --git a/checks/migrator/checks/matching-feature-flags/src/matching_feature_flags.rs b/checks/migrator/checks/matching-feature-flags/src/matching_feature_flags.rs
diff --git a/checks/migrator/checks/sketchpad/Cargo.toml b/checks/migrator/checks/sketchpad/Cargo.toml
@@ -9,22 +9,13 @@ publish = { workspace = true }
 rust-version = { workspace = true }
 
 [dependencies]
-mtma-types = { workspace = true }
 mtma-migrator-types = { workspace = true }
 mtma-migrator-test-types = { workspace = true }
 anyhow = { workspace = true }
-mtma-migrator-test-matching-feature-flags-criterion = { workspace = true }
 mtma-migrator-test-transacting-criterion = { workspace = true }
-mtma-migrator-test-empty-criterion = { workspace = true }
-mtma-node-replay-core = { workspace = true }
-mtma-node-test-global-storage-injective-criterion = { workspace = true }
-mtma-node-test-global-storage-includes-criterion = { workspace = true }
-mtma-node-test-global-storage-not-empty-criterion = { workspace = true }
 mtma-migrator-test-accounts-equal-criterion = { workspace = true }
-mtma-node-preludes = { workspace = true }
 mtma-node-null-core = { workspace = true }
 tokio = { workspace = true }
-chrono = { workspace = true }
 rand = { workspace = true }
 kestrel = { workspace = true }
 mtma-node-test-types = { workspace = true }
@@ -33,7 +24,6 @@ aptos-sdk = { workspace = true }
 [dev-dependencies]
 tracing-test = { workspace = true }
 tracing = { workspace = true }
-tempfile = { workspace = true }
 
 [lints]
 workspace = true
diff --git a/checks/migrator/checks/sketchpad/src/accounts_equal.rs b/checks/migrator/checks/sketchpad/src/accounts_equal.rs
@@ -68,6 +68,6 @@ pub mod test {
 		// exit the test is fine when you only have one test per crate because when cargo test is run across a workspace, it actually multi-processes the tests by crate
 		std::process::exit(0);
 
-		Ok(())
+		// Ok(())
 	}
 }
diff --git a/checks/migrator/checks/sketchpad/src/lib.rs b/checks/migrator/checks/sketchpad/src/lib.rs
@@ -1,3 +1,2 @@
-pub mod matching_feature_flags;
-pub mod transacting;
 pub mod accounts_equal;
+pub mod transacting;
diff --git a/checks/migrator/citeria/balances-equal/src/lib.rs b/checks/migrator/citeria/balances-equal/src/lib.rs
@@ -1,5 +1,5 @@
 use anyhow::Context;
-use bcs_ext::{comparison::BcsEq, conversion::BcsInto};
+use bcs_ext::conversion::BcsInto;
 use mtma_migrator_test_types::criterion::{
 	Criterion, CriterionError, Criterionish, MovementAptosMigrator, MovementMigrator,
 };
@@ -83,7 +83,6 @@ impl Criterionish for BalancesEqual {
 					format!("movement and movement aptos account balances have different values: {:?} != {:?}", movement_account_balance, movement_aptos_account_balance).into(),
 				));
 			}
-			
 		}
 
 		Ok(())

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,6 @@ pub mod test {`
`68`	`68`	`// exit the test is fine when you only have one test per crate because when cargo test is run across a workspace, it actually multi-processes the tests by crate`
`69`	`69`	`std::process::exit(0);`
`70`	`70`
`71`		`- Ok(())`
	`71`	`+ // Ok(())`
`72`	`72`	`}`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+# Migration Executor Checks Sketchpad`
	`2`	`+A sketchpad for playing around with checks on the testpad.`