Merge pull request #56 from movementlabsxyz/l-monninger/events-rcs-contributing-fixes

chore: cleanup contributing and broken links

Author: l-monninger

CONTRIBUTING.md

@@ -2,17 +2,17 @@
 
 | Task | Description |
 |------|-------------|
-| [Upcoming Events](https://github.com/movementlabsxyz/ffs/issues?q=is%3Aissue%20state%3Aopen%20label%3Apriority%3Ahigh%2Cpriority%3Amedium%20label%3Aevent) | High-priority `event` issues with planned completion dates. |
-| [Release Candidates](https://github.com/movementlabsxyz/ffs/issues?q=is%3Aissue%20state%3Aopen%20label%3Arelease-candidate) | Feature-complete versions linked to events. |
-| [Features & Bugs](https://github.com/movementlabsxyz/ffs/issues?q=is%3Aissue%20state%3Aopen%20label%3Afeature%2Cbug%20label%3Apriority%3Aurgent%2Cpriority%3Ahigh) | High-priority `feature` and `bug` issues. |
+| [Upcoming Events](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Apriority%3Ahigh%2Cpriority%3Amedium%20label%3Aevent) | High-priority `event` issues with planned completion dates. |
+| [Release Candidates](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Arelease-candidate%20) | Feature-complete versions linked to events. |
+| [Features & Bugs](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Afeature%2Cbug%20label%3Apriority%3Aurgent%2Cpriority%3Ahigh) | High-priority `feature` and `bug` issues. |
 
 ## How to contribute
 
 We welcome contributions to this project. We manage active development via issues. You may either submit and issue for triage or begin working on something already in the backlog. In both cases, we recommend you follow the initial steps below:
 
-1. **Identify upcoming Events:** check for `priority:urgent` and `priority:high` issues tagged with `event` label [here](https://github.com/movementlabsxyz/ffs/issues?q=is%3Aissue%20state%3Aopen%20label%3Apriority%3Ahigh%2Cpriority%3Amedium%20label%3Aevent%20). These issues mark upcoming events with a planned date for completion and thus a focus of active development. The events will also be sequenced. 
-2. **Identify relevant release Candidates:** one or more release candidates will be linked to an event as sub-issues. Release candidates will entail a feature complete version of the project with a planned date for completion. The date for completion may be after the event date if the event features rolling releases. You can check all release candidates [here](https://github.com/movementlabsxyz/ffs/issues?q=is%3Aissue%20state%3Aopen%20label%3Arelease-candidate).
-3. **Identify high-priority Features and Bugs:** after you've selected your release candidate, review it's sub-issues for potential `feature` and `bug` requests. You check all `priority:urgent` and `priority:high` issues tagged with `feature` or `bug` label [here](https://github.com/movementlabsxyz/ffs/issues?q=is%3Aissue%20state%3Aopen%20label%3Afeature%2Cbug%20label%3Apriority%3Aurgent%2Cpriority%3Ahigh%20).
+1. **Identify upcoming Events:** check for `priority:urgent` and `priority:high` issues tagged with `event` label [here](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Apriority%3Ahigh%2Cpriority%3Amedium%20label%3Aevent). These issues mark upcoming events with a planned date for completion and thus a focus of active development. The events will also be sequenced. 
+2. **Identify relevant release Candidates:** one or more release candidates will be linked to an event as sub-issues. Release candidates will entail a feature complete version of the project with a planned date for completion. The date for completion may be after the event date if the event features rolling releases. You can check all release candidates [here](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Arelease-candidate%20).
+3. **Identify high-priority Features and Bugs:** after you've selected your release candidate, review it's sub-issues for potential `feature` and `bug` requests. You check all `priority:urgent` and `priority:high` issues tagged with `feature` or `bug` label [here](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Afeature%2Cbug%20label%3Apriority%3Aurgent%2Cpriority%3Ahigh).
 
 **New contributors** should prioritize issues tagged with `bug`. 
 
@@ -21,4 +21,4 @@ We welcome contributions to this project. We manage active development via issue
 Those looking to add to the suggest new `features` and `bugs` should identify whether their idea is suitable by considering the existing release candidates and their sub-issues.
 
 **Documentation**
-Visit [sdk/cli/README.md](sdk/cli/README.md) for instructions on how do document when working with the CLI.
+Visit [docs](./docs/) for instructions on how to use existing software. 

README.md

@@ -18,7 +18,7 @@ We otherwise recommend reading the [checks](./checks/README.md) and working down
 | Task | Description |
 |------|-------------|
 | [Upcoming Events](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Apriority%3Ahigh%2Cpriority%3Amedium%20label%3Aevent) | High-priority `event` issues with planned completion dates. |
-| [Release Candidates](https://github.com/movementlabsxyz/movement-migraton/issues?q=is%3Aissue%20state%3Aopen%20label%3Arelease-candidate) | Feature-complete versions linked to events. |
+| [Release Candidates](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Arelease-candidate%20) | Feature-complete versions linked to events. |
 | [Features & Bugs](https://github.com/movementlabsxyz/movement-migration/issues?q=is%3Aissue%20state%3Aopen%20label%3Afeature%2Cbug%20label%3Apriority%3Aurgent%2Cpriority%3Ahigh) | High-priority `feature` and `bug` issues. |
 
 Please see [CONTRIBUTING.md](CONTRIBUTING.md) file for additional contribution guidelines.

migration/util/executor-types/src/executor/movement_aptos_executor.rs

@@ -4,7 +4,7 @@ use aptos_storage_interface::{
 	DbReader,
 };
 use aptos_types::state_store::state_key::StateKey;
-use aptos_vm::aptos_vm::AptosVMBlockExecutor;
+pub use aptos_vm::aptos_vm::AptosVMBlockExecutor;
 use either::Either;
 use std::sync::Arc;
 

migration/util/executor-types/src/executor/movement_executor.rs

@@ -5,6 +5,7 @@ use maptos_opt_executor::aptos_types::state_store::state_key::StateKey;
 pub use maptos_opt_executor::Executor as MovementOptExecutor;
 use std::sync::Arc;
 
+use anyhow::Context;
 pub use maptos_opt_executor;
 pub use maptos_opt_executor::aptos_types::{chain_id::ChainId, state_store::TStateView};
 use tracing::debug;
@@ -40,7 +41,8 @@ impl MovementExecutor {
 	pub fn latest_ledger_version(&self) -> Result<u64, anyhow::Error> {
 		let db_reader = self.opt_executor().db_reader();
 
-		let latest_ledger_info = db_reader.get_latest_ledger_info()?;
+		let latest_ledger_info =
+			db_reader.get_latest_ledger_info().context("failed to get latest ledger info")?;
 
 		Ok(latest_ledger_info.ledger_info().version())
 	}