fix: Change Hashicorp Vault delimiter to a - (#1061)

Author: musitdev

Cargo.lock

@@ -16,6 +16,7 @@ base64 = { workspace = true }
 anyhow = { workspace = true }
 async-trait = { workspace = true }
 uuid = { workspace = true }
+tracing = { workspace = true }
 
 [dev-dependencies]
 tokio = { workspace = true }

util/signing/providers/hashicorp-vault/Cargo.toml

@@ -30,7 +30,8 @@ where
 	async fn build(&self, key: Key) -> Result<HashiCorpVault<C>, SignerBuilderError> {
 		let mut hsm = HashiCorpVault::try_from_env()
 			.map_err(|e| SignerBuilderError::Internal(e.to_string()))?;
-		hsm.set_key_id(key.to_delimited_canonical_string("_"));
+		hsm.set_key_id(key.to_delimited_canonical_string("-"));
+		tracing::info!("HashiCorp Vault builder key name:{}", hsm.get_key_id());
 		if self.create_key {
 			hsm = hsm
 				.create_key()

util/signing/providers/hashicorp-vault/src/hsm/key.rs

@@ -31,6 +31,11 @@ where
 		self.key_name = key_id;
 	}
 
+	/// Sets the key id
+	pub fn get_key_id(&mut self) -> String {
+		self.key_name.clone()
+	}
+
 	/// Tries to create a new HashiCorp Vault HSM from the environment
 	pub fn try_from_env() -> Result<Self, anyhow::Error> {
 		let address = std::env::var("VAULT_ADDRESS").context("VAULT_ADDRESS not set")?;