Merge pull request #281 from layus/fix-dup

layus · web-flow · commit 7f8306601b92 · 2016-09-19T16:16:15.000+02:00
Use dup2 to remove warnings and explicit the intent
diff --git a/vm/boostenv/main/modos.hh b/vm/boostenv/main/modos.hh
@@ -885,8 +885,8 @@ public:
                 raiseLastOSError(vm, "open");
             }
 
-            dup(dn); // stdout
-            dup(dn); // stderr
+            dup2(dn, 1); // stdout
+            dup2(dn, 2); // stderr
           }
 #endif
 
@@ -1090,9 +1090,9 @@ public:
                   close(i);
                 }
               }
-              dup(socketHandle);
-              dup(socketHandle);
-              dup(socketHandle);
+              dup2(socketHandle, 0); // stdin
+              dup2(socketHandle, 1); // stdout
+              dup2(socketHandle, 2); // stderr
 
               auto c_executable = executable.string;
               auto c_argv = new char*[argc+1];

Original file line number	Diff line number	Diff line change
`@@ -885,8 +885,8 @@ public:`
`885`	`885`	`raiseLastOSError(vm, "open");`
`886`	`886`	`}`
`887`	`887`
`888`		`- dup(dn); // stdout`
`889`		`- dup(dn); // stderr`
	`888`	`+ dup2(dn, 1); // stdout`
	`889`	`+ dup2(dn, 2); // stderr`
`890`	`890`	`}`
`891`	`891`	`#endif`
`892`	`892`
`@@ -1090,9 +1090,9 @@ public:`
`1090`	`1090`	`close(i);`
`1091`	`1091`	`}`
`1092`	`1092`	`}`
`1093`		`- dup(socketHandle);`
`1094`		`- dup(socketHandle);`
`1095`		`- dup(socketHandle);`
	`1093`	`+ dup2(socketHandle, 0); // stdin`
	`1094`	`+ dup2(socketHandle, 1); // stdout`
	`1095`	`+ dup2(socketHandle, 2); // stderr`
`1096`	`1096`
`1097`	`1097`	`auto c_executable = executable.string;`
`1098`	`1098`	`auto c_argv = new char*[argc+1];`