Conversation
Codecov Report❌ Patch coverage is
... and 44 files with indirect coverage changes 🚀 New features to boost your workflow:
|
daavoo
reviewed
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Not a blocking strong opinion.
Do you know which providers don't support it?
It seems openai https://github.com/openai/openai-python/blob/main/pyproject.toml does
If our base dependencies support it, maybe it is better to do a runtime exception checking the python version for the providers that don't 🤔
Contributor
Author
|
@daavoo Ooo thank you that's a good point. It's a problem for voyageai and watson providers. I was defaulting to 'eh lets not support it until everybody does' but yeah lets make it more selective. BRB with a solution haha |
- Updated `requires-python` in `pyproject.toml` to allow Python 3.11 and above. - Added conditional imports for `voyageai` and `ibm-watsonx-ai` packages in their respective provider files to handle compatibility with Python 3.14 and above, including specific error messages for users. - Enhanced error message in `AnyLLM` class to provide more context when required packages are missing.
njbrake
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Type
Relevant issues
Checklist
AI Usage Information
I used AoE to make the git worktree so that I could easily branch and write the code.
When answering questions by the reviewer, please respond yourself, do not copy/paste the reviewer comments into an AI system and paste back its answer. We want to discuss with you, not your AI :)