Add max_completion_tokens to gateway ChatCompletionRequest#817
Merged
njbrake merged 1 commit intomozilla-ai:mainfrom Feb 20, 2026
Merged
Conversation
Newer OpenAI models (o-series, gpt-5-nano, etc.) require max_completion_tokens instead of max_tokens. The underlying acompletion() call already supports it, but the gateway's Pydantic schema was stripping the field from incoming requests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_completion_tokens: int | None = Noneto theChatCompletionRequestPydantic model in the gateway's chat routemax_completion_tokensinstead of the legacymax_tokensparameteracompletion()already supports this kwarg, but the gateway schema was silently stripping it from incoming requests since it wasn't declared on the modelDetails
OpenAI's newer reasoning models (
o1,o3-mini,gpt-5-nano, etc.) reject requests that usemax_tokensand requiremax_completion_tokensinstead. Clients sending this field to the gateway get it dropped by Pydantic validation, causing either unbounded generation or provider errors.This one-line addition to
ChatCompletionRequestallows the field to pass throughmodel_dump()into theacompletion(**completion_kwargs)call, which already handles it correctly.Test plan
max_tokensbehavior is unchangedmax_completion_tokensset and confirm it reaches the provider