Skip to content

Commit ee8e1d2

Browse files
authored
Include log file path (when configured) in dev banner (#109)
* Include log file path (when configured) in dev banner * Tweak format of config validation errors on startup
1 parent 69dce04 commit ee8e1d2

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

cmd/daemon.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,19 @@ func (c *DaemonCmd) run(_ *cobra.Command, _ []string) error {
117117
// Print --dev mode banner if required.
118118
if c.Dev {
119119
logger.Info("Launching daemon in dev mode", "addr", addr)
120-
fmt.Printf("mcpd daemon running in 'dev' mode.\n\n"+
120+
banner := fmt.Sprintf("mcpd daemon running in 'dev' mode.\n\n"+
121121
" Local API:\thttp://%s/api/v1\n"+
122122
" OpenAPI UI:\thttp://%s/docs\n"+
123123
" Config file:\t%s\n"+
124-
" Secrets file:\t%s\n\n"+
125-
"Press Ctrl+C to stop.\n\n", addr, addr, flags.ConfigFile, flags.RuntimeFile)
124+
" Secrets file:\t%s\n",
125+
addr, addr, flags.ConfigFile, flags.RuntimeFile)
126+
127+
if flags.LogPath != "" {
128+
banner += fmt.Sprintf(" Log file:\t%s => (%s)\n", flags.LogPath, flags.LogLevel)
129+
}
130+
131+
banner += "\nPress Ctrl+C to stop.\n\n"
132+
fmt.Print(banner)
126133
}
127134

128135
select {

internal/daemon/daemon.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ func NewDaemon(apiAddr string, opts *Opts) (*Daemon, error) {
8282
}
8383
}
8484
if validateErrs != nil {
85-
return nil, fmt.Errorf("invalid runtime configuration: %w", validateErrs)
85+
// NOTE: Include a line break in the output to improve readability of the validation errors.
86+
return nil, fmt.Errorf("invalid runtime configuration:\n%w", validateErrs)
8687
}
8788

8889
healthTracker := NewHealthTracker(serverNames)

0 commit comments

Comments
 (0)