-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Why are you returning an empty
ServerEntrystruct instead ofnil?
Originally posted by @dpoulopoulos in #173
There are places in the existing code base where we should consider returning a value type over a pointer...
e.g. DefaultCacheTTL and transformValueArg
But also, some places that should likely stay as they are, returning a pointer:
NewHealthTrackerNewClientManagerNewExecutionContextConfigNewCLIArgParser
Because they manage a lot of state or deal with large structs.
Refactor the following to return value types not pointers:
DefaultCacheTTLtransformValueArg
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers