Skip to content

Commit eb4c8a5

Browse files
committed
Merge branch 'master' into development
* master: Bug 1965553 - Uplift approval set in bugzilla without relman approval
2 parents 783afb9 + 06d1029 commit eb4c8a5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

extensions/PhabBugz/lib/Util.pm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ sub set_attachment_approval_flags {
128128
return;
129129
}
130130

131-
# If setting to + or - then user needs to be a release manager.
131+
# If setting to + then the Phabricator user needs to be a release manager.
132132
if (($status eq '+' || $status eq '-') && !$phab_user->is_release_manager) {
133133
INFO(
134134
"Unable to set existing `$approval_flag_name` flag to `$status` due to not being a release manager."
@@ -146,7 +146,8 @@ sub set_attachment_approval_flags {
146146
if (!@old_flags && $status ne 'X') {
147147
my $approval_flag = Bugzilla::FlagType->new({name => $approval_flag_name});
148148
if ($approval_flag) {
149-
# If setting to + then at least one accepted reviewer needs to be a release manager.
149+
150+
# If setting to + then at least one accepted reviewer needs to be a release manager.
150151
if ($status eq '+' && !$phab_user->is_release_manager) {
151152
INFO(
152153
"Unable to create new `$approval_flag_name` flag with status `$status` due to not being accepted by a release manager."

0 commit comments

Comments
 (0)