Skip to content

Commit 8b7eb48

Browse files
committed
Fixed review comments
1 parent b95c05f commit 8b7eb48

File tree

9 files changed

+1744
-1788
lines changed

9 files changed

+1744
-1788
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Use the latest stable Python image
2-
FROM python:3.11-slim
2+
FROM python:3.14.2-slim
33

44
# Set environment variables
55
ENV PYTHONDONTWRITEBYTECODE=1 \
@@ -34,4 +34,4 @@ RUN chown -R app:app /app
3434
USER app
3535

3636
# Set the default command
37-
CMD ["python", "main.py"]
37+
CMD ["python", "main.py"]

Dockerfile.mock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Dockerfile for mock GitHub API service
2-
FROM python:3.11-slim
2+
FROM python:3.14.2-slim
33

44
WORKDIR /app
55

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ docker run --rm \
6666

6767
### Container Specifications
6868

69-
- **Base Image**: `python:3.11-slim` (latest stable Python)
69+
- **Base Image**: `python:3.14.2-slim` (latest stable Python)
7070
- **User**: `app` (uid: 1000, gid: 1000)
7171
- **Working Directory**: `/app`
7272
- **Ownership**: All files in `/app` are owned by the `app` user

TESTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ If coverage is below 80%:
604604

605605
### Tests Pass Locally But Fail in CI
606606

607-
- Check Python version (must be 3.11)
607+
- Check Python version (must be 3.14)
608608
- Verify all dependencies are in `requirements.txt`
609609
- Look for environment-specific issues
610610

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ dependencies = [
2525
[project.optional-dependencies]
2626
dev = [
2727
"pytest>=7.0.0",
28+
"pytest-mock>=3.10.0",
2829
"ruff>=0.14.14",
2930
"black>=24.0.0",
3031
]

pytest.ini

Lines changed: 0 additions & 47 deletions
This file was deleted.

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# This file is autogenerated by pip-compile with Python 3.14
2+
# This file is autogenerated by pip-compile with Python 3.10
33
# by the following command:
44
#
55
# pip-compile --generate-hashes pyproject.toml

test_formatting.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
"""
2+
Code Style Tests.
3+
"""
4+
5+
import subprocess
6+
7+
8+
def test_black():
9+
cmd = ("black", "--diff", "main.py")
10+
output = subprocess.check_output(cmd)
11+
assert not output, "The python code does not adhere to the project style."
12+
13+
14+
def test_ruff():
15+
passed = subprocess.call(("ruff", "check", "main.py", "--target-version", "py314"))
16+
assert not passed, "ruff did not run cleanly."

0 commit comments

Comments
 (0)