landing_job: add Job.is_pull_request_job field (bug 2004764)

Author: zzzeid

src/lando/api/tests/test_landings.py

@@ -391,6 +391,7 @@ def test_integrated_execute_job_pull_request(
         "requester_email": "test@example.com",
         "target_repo": repo,
         "attempts": 1,
+        "is_pull_request_job": True,
     }
     job = make_landing_job(revisions=revisions, **job_params)
 

src/lando/api/views.py

@@ -258,7 +258,9 @@ class Form(forms.Form):
             return JsonResponse(form.errors, 400)
 
         job = LandingJob.objects.create(
-            target_repo=target_repo, requester_email=ldap_username
+            target_repo=target_repo,
+            requester_email=ldap_username,
+            is_pull_request_job=True,
         )
         author_name, author_email = pull_request.author
 

src/lando/main/migrations/0040_landingjob_is_pull_request_job.py

@@ -0,0 +1,18 @@
+# Generated by Django 5.2.8 on 2025-12-08 19:30
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("main", "0039_alter_repo_hooks_PreventDotGithubCheck"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="landingjob",
+            name="is_pull_request_job",
+            field=models.BooleanField(blank=True, default=False),
+        ),
+    ]

src/lando/main/models/landing_job.py

@@ -46,10 +46,7 @@ class LandingJob(BaseJob):
         Revision, through="RevisionLandingJob", related_name="landing_jobs"
     )
 
-    @property
-    def is_pull_request_job(self) -> bool:
-        """Return True if all revisions in the landing job have a pull_number set."""
-        return not self.revisions.filter(pull_number__isnull=True).exists()
+    is_pull_request_job = models.BooleanField(default=False, blank=True)
 
     @property
     def landed_phabricator_revisions(self) -> dict: