main.scm: move COMMIT_ID_HEX_LENGTH from pushlog (no bug) r=zeid

Small cleanup in preparation for the const to be used in more places.

Pull request: #766

Author: shtrom

src/lando/main/scm/__init__.py

@@ -1,6 +1,7 @@
 from lando.main.scm.abstract_scm import AbstractSCM
 from lando.main.scm.commit import CommitData
 from lando.main.scm.consts import (
+    COMMIT_ID_HEX_LENGTH,
     SCM_TYPE_GIT,
     SCM_TYPE_HG,
     MergeStrategy,
@@ -39,6 +40,7 @@
     # commit
     "CommitData",
     # consts
+    "COMMIT_ID_HEX_LENGTH",
     "SCM_TYPE_HG",
     "SCM_TYPE_GIT",
     "MergeStrategy",

src/lando/main/scm/consts.py

@@ -3,6 +3,8 @@
 SCM_TYPE_GIT = "git"
 SCM_TYPE_HG = "hg"
 
+COMMIT_ID_HEX_LENGTH = 40
+
 
 @enum.unique
 class MergeStrategy(str, enum.Enum):

src/lando/pushlog/models/commit.py

@@ -11,9 +11,9 @@
 from lando.main.models import Repo
 
 # We need to import from the specific file to avoid dependency loops.
-from lando.main.scm.commit import CommitData
+from lando.main.scm import COMMIT_ID_HEX_LENGTH, CommitData
 
-from .consts import COMMIT_ID_HEX_LENGTH, MAX_FILENAME_LENGTH, MAX_PATH_LENGTH
+from .consts import MAX_FILENAME_LENGTH, MAX_PATH_LENGTH
 
 logger = logging.getLogger(__name__)
 

src/lando/pushlog/models/consts.py

@@ -1,5 +1,3 @@
-COMMIT_ID_HEX_LENGTH = 40
-
 # Those are fairly common values under Unix.
 MAX_FILENAME_LENGTH = 255
 MAX_PATH_LENGTH = 4096