landing_worker: update try_task_config.json (bug 2013005) r=sheehan

Pull request: #882

Author: zzzeid

src/lando/api/legacy/workers/landing_worker.py

@@ -182,16 +182,16 @@ def add_try_task_config(self, scm: AbstractSCM, **github_params):
         NOTE: try_task_config value will be a copy of provided github_params
         with keys prepended with "github_".
         """
-        allowed_params = (
+        required_params = {
             "pull_number",
             "pull_head_sha",
             "repo_url",
             "branch",
-        )
-        if not set(github_params).issubset(allowed_params):
+        }
+        if set(github_params) != required_params:
             raise ValueError(
-                "Disallowed parameter(s) passed: "
-                f"{set(allowed_params).difference(github_params)}"
+                "Missing or disallowed parameter(s) passed: "
+                f"{required_params.symmetric_difference(github_params)}"
             )
 
         with (Path(scm.path) / "try_task_config.json").open("x") as f:
@@ -201,7 +201,7 @@ def add_try_task_config(self, scm: AbstractSCM, **github_params):
                     "target_tasks_method": "codereview",
                     "try_mode": "try_task_config",
                     "try_task_config": {
-                        f"github_{k}": v for k, v in github_params.items()
+                        "github": github_params,
                     },
                 },
                 "version": 2,

src/lando/api/tests/test_landings.py

@@ -284,7 +284,7 @@
 --- /dev/null
 +++ b/try_task_config.json
 @@ -0,0 +1 @@
-+{{"parameters": {{"optimize_target_tasks": true, "target_tasks_method": "codereview", "try_mode": "try_task_config", "try_task_config": {{"github_pull_number": 1, "github_pull_head_sha": null, "github_repo_url": "{}", "github_branch": "main"}}}}, "version": 2}}
++{{"parameters": {{"optimize_target_tasks": true, "target_tasks_method": "codereview", "try_mode": "try_task_config", "try_task_config": {{"github": {{"pull_number": 1, "pull_head_sha": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "repo_url": "{}", "branch": "main"}}}}}}, "version": 2}}
 \\ No newline at end of file
 """.lstrip()
 
@@ -1355,6 +1355,7 @@ def make_handover_job(
     def _make_handover_job(target_repo: Repo, handover_repo: Repo) -> LandingJob:
         revision = create_patch_revision(1)
         revision.pull_number = 1
+        revision.pull_head_sha = "a" * 40
         revision.patches = revision.patch
         revision.patch_data = {
             "author_name": "someone",