Skip to content

Commit ecf3c3e

Browse files
committed
admin: provide links back to public job and revision pages (bug 2019488) r=sheehan,zeid
Pull request: #952
1 parent a9f2b20 commit ecf3c3e

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

src/lando/main/admin.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from django.forms import CheckboxSelectMultiple, MultipleChoiceField
77
from django.forms import Field as FormField
88
from django.http import HttpRequest
9+
from django.urls import reverse
910
from django.utils.translation import gettext_lazy
1011

1112
from lando.main.models import (
@@ -112,9 +113,14 @@ class JobAdmin(admin.ModelAdmin):
112113
)
113114
search_fields = ("requester_email", "landed_commit_id")
114115

116+
def view_on_site(self, instance: LandingJob) -> str:
117+
url = reverse("jobs-page", kwargs={"job_id": instance.id})
118+
return url
119+
115120

116121
class LandingJobAdmin(JobAdmin):
117122
model = LandingJob
123+
118124
list_display = (
119125
"id",
120126
"revisions",
@@ -251,6 +257,12 @@ class RevisionAdmin(admin.ModelAdmin):
251257
)
252258
search_fields = ("revision_id",)
253259

260+
def view_on_site(self, instance: Revision) -> str | None:
261+
if not instance.revision_id:
262+
return None
263+
url = reverse("revisions-page", kwargs={"revision_id": instance.revision_id})
264+
return url
265+
254266
def revision(self, instance: Revision) -> str:
255267
"""Return a Phabricator-like revision identifier."""
256268
idstr = f"{instance.id}"

0 commit comments

Comments
 (0)