Bug 2016831 - Include acting_capacity in Review Helper requests (#73)

Author: suhaibmujahid

moz-extensions/src/reviewhelper/controller/ReviewHelperController.php

@@ -5,6 +5,32 @@
 
 abstract class ReviewHelperController extends PhabricatorController {
 
+  protected function determineActingCapacity(
+    PhabricatorUser $viewer,
+    DifferentialRevision $revision
+  ) {
+    if ($viewer->getPHID() === $revision->getAuthorPHID()) {
+      return 'author';
+    }
+
+    foreach ($revision->getReviewers() as $reviewer) {
+      if ($reviewer->getReviewerPHID() === $viewer->getPHID()) {
+        return 'reviewer:' . $reviewer->getReviewerStatus();
+      }
+    }
+
+    $subscribers = id(new PhabricatorSubscribersQuery())
+      ->withObjectPHIDs(array($revision->getPHID()))
+      ->withSubscriberPHIDs(array($viewer->getPHID()))
+      ->execute();
+
+    if (!empty($subscribers[$revision->getPHID()])) {
+      return 'participant';
+    }
+
+    return null;
+  }
+
   /**
    * Make a request to the Review Helper service.
    *

moz-extensions/src/reviewhelper/controller/ReviewHelperFeedbackController.php

@@ -51,11 +51,35 @@ private function submitFeedback(
     $comment_id,
     $feedback_type
   ) {
+    $comment = id(new DifferentialDiffInlineCommentQuery())
+      ->setViewer($viewer)
+      ->withIDs(array($comment_id))
+      ->executeOne();
+
+    if (!$comment) {
+      throw new ReviewHelperServiceException(
+        pht('Comment not found or you do not have permission to view it.')
+      );
+    }
+    $revision = id(new DifferentialRevisionQuery())
+      ->setViewer($viewer)
+      ->withPHIDs(array($comment->getRevisionPHID()))
+      ->needReviewers(true)
+      ->executeOne();
+
+    if (!$revision) {
+      throw new ReviewHelperServiceException(
+        pht('Unable to load revision for this comment.')
+      );
+    }
+    $acting_capacity = $this->determineActingCapacity($viewer, $revision);
+
     $payload = array(
       'comment_id' => $comment_id,
       'feedback_type' => $feedback_type,
       'user_id' => $viewer->getID(),
       'user_name' => $viewer->getUsername(),
+      'acting_capacity' => $acting_capacity,
     );
 
     return $this->makeServiceRequest('/feedback', $payload);

moz-extensions/src/reviewhelper/controller/ReviewHelperRequestController.php

@@ -13,6 +13,7 @@ public function handleRequest(AphrontRequest $request) {
       ->setViewer($viewer)
       ->withIDs(array($revision_id))
       ->needDiffIDs(true)
+      ->needReviewers(true)
       ->executeOne();
 
     if (!$revision) {
@@ -65,11 +66,14 @@ private function requestReview(
     PhabricatorUser $viewer,
     DifferentialRevision $revision
   ) {
+    $acting_capacity = $this->determineActingCapacity($viewer, $revision);
+
     $payload = array(
       'revision_id' => $revision->getID(),
       'diff_id' => max($revision->getDiffIDs()),
       'user_id' => $viewer->getID(),
       'user_name' => $viewer->getUsername(),
+      'acting_capacity' => $acting_capacity,
     );
 
     $data = $this->makeServiceRequest('/request', $payload);