Skip to content

Commit 98d37e1

Browse files
Low hanging a11y fixes (#230)
This PR contains a few quick fixes for issues unearthed in the recent accessibility audit. Fixes FXVPN-429, 431, 434, 436, 427, 433, 437.
1 parent 1aea1be commit 98d37e1

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/components/message-screen.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,12 @@ export class MessageScreen extends LitElement {
6161
<vpn-titlebar title=${this.titleHeader}></vpn-titlebar>
6262
<div class="inner">
6363
<div class="upper">
64-
<img class="${this.identifier}" src="/assets/img/${this.img}" />
65-
<h1>${this.heading}</h1>
64+
<img
65+
class="${this.identifier}"
66+
src="/assets/img/${this.img}"
67+
aria-hidden="true"
68+
/>
69+
<h2>${this.heading}</h2>
6670
<slot></slot>
6771
</div>
6872
${when(
@@ -225,7 +229,7 @@ export class MessageScreen extends LitElement {
225229
background: var(--action-button-color);
226230
}
227231
228-
h1 {
232+
h2 {
229233
font-family: var(--font-family-bold);
230234
margin-block: 16px;
231235
color: #3d3d3d;
@@ -267,7 +271,7 @@ export class MessageScreen extends LitElement {
267271
}
268272
269273
@media (prefers-color-scheme: dark) {
270-
h1 {
274+
h2 {
271275
color: #ffffff;
272276
}
273277

src/ui/firstRun/firstRun.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class FirstRunPage extends LitElement {
4343
<main>
4444
<h1>${tr("thankYouForAdding")}</h1>
4545
<div class="flex-row">
46-
<img src="firstrun.svg" />
46+
<img src="firstrun.svg" aria-hidden="true" />
4747
<div class="copy">
4848
<p class="bold p1">${tr("optionalDataCollection")}</p>
4949
<p class="p1">${tr("first-install-body")}</p>

0 commit comments

Comments
 (0)