Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.prototype.with. r=jandem

Test case in <tc39/test262#4477>.

Differential Revision: https://phabricator.services.mozilla.com/D248928

Author: anba

js/src/builtin/Array.cpp

@@ -3740,8 +3740,8 @@ static bool array_toSpliced(JSContext* cx, unsigned argc, Value* vp) {
   return true;
 }
 
-// https://github.com/tc39/proposal-change-array-by-copy
-// Array.prototype.with()
+// ES2026 draft rev a562082b031d89d00ee667181ce8a6158656bd4b
+// Array.prototype.with ( index, value )
 static bool array_with(JSContext* cx, unsigned argc, Value* vp) {
   AutoJSMethodProfilerEntry pseudoFrame(cx, "Array.prototype", "with");
   CallArgs args = CallArgsFromVp(argc, vp);
@@ -3761,7 +3761,6 @@ static bool array_with(JSContext* cx, unsigned argc, Value* vp) {
   // Step 3. Let relativeIndex be ? ToIntegerOrInfinity(index).
   double relativeIndex;
   if (!ToInteger(cx, args.get(0), &relativeIndex)) {
-    JS_ReportErrorNumberASCII(cx, GetErrorMessage, nullptr, JSMSG_BAD_INDEX);
     return false;
   }
 

js/src/jit-test/tests/errors/bug-1886940.js

@@ -1,2 +1,2 @@
-// |jit-test| error: RangeError
+// |jit-test| error: TypeError
 [].with(Symbol.hasInstance);