fix(publishers): code accesses status_code; ok is a property not a fn

Jira: Untracked

Author: bheesham

python-modules/cis_publisher/tests/test_ldap.py

@@ -25,13 +25,12 @@ class FakeResponse:
             def __init__(self, fake={}):
                 self.fake = fake
                 self.text = str(fake)
+                self.ok = True
+                self.status_code = 200
 
             def json(self):
                 return self.fake
 
-            def ok(self):
-                return True
-
         mock_request_post.return_value = FakeResponse()
         mock_request_get.return_value = FakeResponse(self.mu)
         mock_validate.return_value = True

python-modules/cis_publisher/tests/test_publisher.py

@@ -34,13 +34,11 @@ class FakeResponse:
             def __init__(self, fake={}):
                 self.fake = fake
                 self.text = str(fake)
+                self.ok = True
 
             def json(self):
                 return self.fake
 
-            def ok(self):
-                return True
-
         mock_request_get.return_value = FakeResponse(fake=self.mu)
 
         profiles = [cis_profile.User()]
@@ -59,13 +57,11 @@ class FakeResponse:
             def __init__(self, fake={}):
                 self.fake = fake
                 self.text = str(fake)
+                self.ok = True
 
             def json(self):
                 return self.fake
 
-            def ok(self):
-                return True
-
         mock_request_get.return_value = FakeResponse(fake=self.mu2)
 
         profiles = [cis_profile.User()]
@@ -88,8 +84,8 @@ def test_post(self, mock_authzero, mock_secrets, mock_request_post):
         mock_secrets.return_value = "is_pretty_cool"
 
         class FakeResponse:
-            def ok(self):
-                return True
+            def __init__(self):
+                self.ok = True
 
         mock_request_post.return_value = FakeResponse()
         profiles = [cis_profile.User()]
@@ -110,13 +106,11 @@ class FakeResponse:
             def __init__(self, fake={}):
                 self.fake = fake
                 self.text = str(fake)
+                self.ok = True
 
             def json(self):
                 return self.fake
 
-            def ok(self):
-                return True
-
         mock_request_post.return_value = FakeResponse()
         mock_request_get.return_value = FakeResponse(fake=self.mu)
 
@@ -144,13 +138,12 @@ class FakeResponse:
             def __init__(self, fake={}):
                 self.fake = fake
                 self.text = str(fake)
+                self.ok = True
+                self.status_code = 200
 
             def json(self):
                 return self.fake
 
-            def ok(self):
-                return True
-
         mock_request_post.return_value = FakeResponse()
         mock_request_get.return_value = FakeResponse(fake=self.mu)
         profiles = [cis_profile.User(user_id="test")]
@@ -170,13 +163,11 @@ class FakeResponse:
             def __init__(self, fake={}):
                 self.fake = fake
                 self.text = str(fake)
+                self.ok = True
 
             def json(self):
                 return self.fake
 
-            def ok(self):
-                return True
-
         mock_request_post.return_value = FakeResponse()
         mock_request_get.return_value = FakeResponse(fake=self.mu)