Skip to content

Commit f6e5387

Browse files
authored
fix(docker-build): added checkout step, changed required to false for region and build context (#53)
* fix(docker-build): added checkout step, changed required to false for region and build context * fix(docker-build): removing checkout step from docker-build action * fix(deploy): updated checkout step to set persist-credentials: false
1 parent bdc51fd commit f6e5387

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

deploy/action.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ runs:
7979
repository: ${{ inputs.infra_repo }}
8080
ref: ${{ inputs.infra_repo_ref }}
8181
ssh-key: ${{ inputs.infra_repo_ssh_key }}
82+
persist-credentials: false
8283

8384
- id: deployment_service_account
8485
name: deployment service account

docker-build/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ inputs:
66
required: true
77
gar_location:
88
description: GCP region where GAR is located
9-
required: true
9+
required: false
1010
default: us
1111
gar_name:
1212
description: GAR Name
@@ -16,7 +16,7 @@ inputs:
1616
required: true
1717
image_build_context:
1818
description: Path to image context for `docker build`
19-
required: true
19+
required: false
2020
default: ./
2121
image_tag_metadata:
2222
description: Optional metadata to append to image tag (e.g. for a tagged commit `v1.2.3` and metadata `dev`, the final image tag will be `v1.2.3--dev`)
@@ -28,7 +28,7 @@ inputs:
2828
should_tag_latest:
2929
description: Whether to tag images as `latest`.
3030
required: false
31-
default: "false"
31+
default: "false"
3232

3333
outputs:
3434
image_tags:

0 commit comments

Comments
 (0)