Merge pull request #748 from mozilla-lockbox/master

Release version 0.1.10-alpha

Author: devinreams

.babelrc

@@ -1,17 +1,26 @@
 {
   "presets": [
-    "react",
-    ["env", {"targets": {"browsers": ["firefox >= 56"]}}]
+    "@babel/preset-react",
+    ["@babel/preset-env", {
+      "targets": {"browsers": ["firefox >= 56"]},
+      "useBuiltins": true,
+      "modules": false
+    }]
   ],
   "plugins": [
-    ["transform-object-rest-spread", {"useBuiltins": true}]
+    "@babel/plugin-syntax-object-rest-spread",
+    "@babel/plugin-syntax-async-generators"
   ],
   "env": {
+    "production": {
+      "presets": [
+        "minify"
+      ]
+    },
     "test": {
       "plugins": [
         "istanbul",
-        "rewire",
-        "transform-runtime"
+        "rewire"
       ]
     }
   }

docs/.dir-locals.el .dir-locals.eldocs/.dir-locals.el renamed to .dir-locals.el

@@ -33,5 +33,7 @@ module.exports = {
     "curly": "error",
     "no-console": "warn",
     "semi": "error",
+    "mozilla/no-define-cc-etc": "off",
+    "mozilla/use-chromeutils-import": "off",
   },
 };

.eslintrc.js

@@ -0,0 +1,31 @@
+---
+name: Bug report
+about: Create a bug report to help us improve
+
+---
+
+*Please note: this project is not currently or actively planning to fix non-critical (data loss, security related) bugs. This is an experimental prototype.*
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser version [e.g. 62, Nightly 63.a.01)
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,19 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+
+---
+
+*Please note: your idea may have already been considered and you may find it in an issue by searching this repository. Also, this project is not currently or actively planning to implement new features as it is an experimental prototype.*
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -12,3 +12,4 @@ __pycache__
 .tox
 *.log
 *.pyc
+.pytest_cache

.gitignore

@@ -21,7 +21,7 @@ jobs:
       apt:
         packages:
           - jwm
-      env: TOXENV=integration-tests MOZ_HEADLESS=1 GECKODRIVER=0.19.1
+      env: TOXENV=integration-tests MOZ_HEADLESS=1 GECKODRIVER=0.21.0
       before_install:
         - wget -O /tmp/geckodriver.tar.gz https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER/geckodriver-v$GECKODRIVER-linux64.tar.gz
         - mkdir $HOME/geckodriver && tar xvf /tmp/geckodriver.tar.gz -C $HOME/geckodriver
@@ -37,6 +37,30 @@ jobs:
       script: tox
       after_success: skip
       before_deploy: skip
+    - stage:
+      language: python
+      python: 3.6
+      addons:
+        firefox: latest-nightly
+      apt:
+        packages:
+          - jwm
+      env: TOXENV=accessibility MOZ_HEADLESS=1 GECKODRIVER=0.21.0
+      before_install:
+        - wget -O /tmp/geckodriver.tar.gz https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER/geckodriver-v$GECKODRIVER-linux64.tar.gz
+        - mkdir $HOME/geckodriver && tar xvf /tmp/geckodriver.tar.gz -C $HOME/geckodriver
+        - export PATH=$HOME/geckodriver:$PATH
+        - firefox --version
+        - geckodriver --version
+      install:
+        - nvm install node
+        - pip install tox
+      before_script:
+        - npm install
+        - npm run package
+      script: tox -e a11y
+      after_success: skip
+      before_deploy: skip
     - stage:
       language: python
       python: 3.6
@@ -49,20 +73,21 @@ jobs:
     - stage:
       <<: *node
       before_deploy: skip
-    - stage: deploy
-      if: branch = master
-      <<: *node
-      python: '3.6'
-      script: skip
-      deploy:
-        edge:
-          branch: v1.8.47
-        provider: pages
-        on:
-          branch: master
-        skip_cleanup: true
-        local_dir: site
-        github_token: $GITHUB_TOKEN
+    # Re-enable this when `documentation` updates to support Babel 7.
+    # - stage: deploy
+    #   if: branch = master
+    #   <<: *node
+    #   python: '3.6'
+    #   script: skip
+    #   deploy:
+    #     edge:
+    #       branch: v1.8.47
+    #     provider: pages
+    #     on:
+    #       branch: master
+    #     skip_cleanup: true
+    #     local_dir: site
+    #    github_token: $GITHUB_TOKEN
     # deploy tags to GitHub Releases
     - stage: deploy
       if: tag =~ ^\d.\d.\d
@@ -79,12 +104,13 @@ jobs:
 
 script:
   - STRICT_LINT=1 npm run test
-  - npm run nsp
+  - npx nsp check || true
 
 after_success:
   - npm run codecov
 
 before_deploy:
   - pip install --user mkdocs
   - npm run package
-  - npm run doc
+  # Re-enable this when `documentation` updates to support Babel 7.
+  # - npm run doc

.travis.yml

@@ -5,12 +5,11 @@
 
 # Lockbox for Firefox
 
-Lockbox for Firefox is a work-in-progress extension for Firefox to improve upon
-Firefox's built-in password management. If you're interested, you should
-probably come back later when we have more to show!
+Lockbox for Firefox is an experimental extension prototype for Firefox.
 
-:warning: **Note: This is a rapidly evolving prototype that will change. Any
-data stored here is not guaranteed to be retained in future updates.**
+:warning: **Note: This is no longer an actively-developed prototype and not
+officially supported. Any data stored is not guaranteed to be retained in
+future updates.**
 
 ## [Quick Installation][install-link]
 
@@ -32,6 +31,9 @@ please see the [`docs` directory][docs-link].
 
 ## Contributing ##
 
+:warning: **Note: This is not an actively-developed prototype and we are not
+actively seeking contributions at this time.**
+
 See the [guidelines][contributing-link] for contributing to this project.
 
 This project is governed by a [Code Of Conduct][coc-link].
@@ -49,7 +51,7 @@ version 2.0][license-link].
 [waffle-link]: https://waffle.io/mozilla-lockbox/lockbox-extension
 [greenkeeper-image]: https://badges.greenkeeper.io/mozilla-lockbox/lockbox-extension.svg
 [greenkeeper-link]: https://greenkeeper.io/
-[install-link]: /docs/install.md
+[install-link]: /docs/developer/install.md
 [org-website]: https://mozilla-lockbox.github.io/
 [docs-link]: /docs
 [contributing-link]: docs/contributing.md

README.md

@@ -2,8 +2,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import fs from "fs";
-import path from "path";
+const fs = require("fs");
+const path = require("path");
 
 function statPromise(path) {
   return new Promise((resolve, reject) => {
@@ -13,7 +13,7 @@ function statPromise(path) {
   });
 }
 
-export default class DirListWebpackPlugin {
+module.exports = class DirListWebpackPlugin {
   constructor(options) {
     this.options = {
       directory: undefined,
@@ -83,4 +83,4 @@ export default class DirListWebpackPlugin {
       });
     });
   }
-}
+};

dir-list-webpack-plugin.js

@@ -1,15 +1,33 @@
 # lockbox-extension code owners
 # https://help.github.com/articles/about-codeowners/
 
-# tests should also be reviewed by @m8ttyB
-/test/    @jimporter @m8ttyB
+# integration tests and related config are maintained by PI
+/requirements/              @mozilla-lockbox/product-integrity
+/test/integration/          @mozilla-lockbox/product-integrity
+/.pyup.ini                  @mozilla-lockbox/product-integrity
+/setup.cfg                  @mozilla-lockbox/product-integrity
+/tox.ini                    @mozilla-lockbox/product-integrity
 
-# docs are shepherded by @devinreams
-/docs/    @jimporter @devinreams
+# test plans are maintained by PI
+/docs/developer/test-plan*  @mozilla-lockbox/product-integrity
+
+# metrics docs are maintained by Leif
+/docs/metrics.md            @irrationalagent 
+
+# unit tests and related config are maintained by engineering
+/test/unit/                 @mozilla-lockbox/desktop-engineering
+/test/                      @mozilla-lockbox/desktop-engineering
+
+# source code and all other docs are maintained by engineering
+/src/                       @mozilla-lockbox/desktop-engineering
+/docs/                      @mozilla-lockbox/desktop-engineering
+
+# release notes are maintained by the product owners
+/docs/release-notes.md      @mozilla-lockbox/product
 
 # include Flod for l10n string changes
 # @todo uncomment below after initial string freeze
 #src/webextension/locales/en-US/*.ftl    @flodolo
 
-# otherwise, everything is to be reviewed by @jimporter
-*         @jimporter
+# otherwise, everything is to be reviewed by the desktop team
+*                           @mozilla-lockbox/desktop-engineering