Fluent issues

[flodolo]

I realized there are Fluent files in the repo, and someone is trying to localize them with pull requests, so I took a look. CC @stasm

product-title = Lockbox
firstrun-intro-title = Welcome to { product-title }

Product title should likely be defined as a term.

-product-title = Lockbox
firstrun-intro-title = Welcome to { -product-title }

I would also object that that's the product's name, not title.

item-summary-title =
  { $length ->
     [0]     (no site name)
    *[other] { $title }
}

item-summary-username =
  { $length ->
     [0]     (no username)
    *[other] { $username }
}

breadcrumbs-item =
  { $length ->
     [0]     (no site name)
    *[other] { $title }
}

These are abusing plural forms to avoid having logic in the code. You should just have a string used when there's no element, or display the variable directly when there is one.

Nit: I would avoid empty lines and unnecessary new lines

intro-page-step-2 =
  Click the { product-title } icon to see all the entries you've saved.
  .title = Go straight to your logins

Should just be:

intro-page-step-2 = Click the { product-title } icon to see all the entries you've saved.
  .title = Go straight to your logins

Note for all the string: you should use a proper apostrophe ’ instead of a straight quote '.

modal-cancel-editing = Unsaved changes exist. Discard them?
  .confirmLabel = Discard Changes
  .cancelLabel = Go Back

I'm not a fan of this approach. If you ever need to change one of the three strings, you'll need to throw away all 3 of them.

[devinreams]

Thanks for the string review @flodolo. 🙇

Since we're not planning on any additional work on the extension at this time we don't expect to make this changes ourselves but I'll leave this open for future consideration.