Bug 1691829: Specify interface for nsIFilePicker::files getter on Cocoa. r=mccr8

kmaglione · kmaglione · commit b1da942cbeb3 · 2021-02-09T22:06:02.000Z
Without this, JS callers which don't explicitly query every element returned by the enumerator are broken only on MacOS. Differential Revision: https://phabricator.services.mozilla.com/D104580
diff --git a/widget/cocoa/nsFilePicker.mm b/widget/cocoa/nsFilePicker.mm
@@ -593,7 +593,7 @@ - (void)menuChangedItem:(NSNotification*)aSender {
 }
 
 NS_IMETHODIMP nsFilePicker::GetFiles(nsISimpleEnumerator** aFiles) {
-  return NS_NewArrayEnumerator(aFiles, mFiles);
+  return NS_NewArrayEnumerator(aFiles, mFiles, NS_GET_IID(nsIFile));
 }
 
 NS_IMETHODIMP nsFilePicker::SetDefaultString(const nsAString& aString) {

Original file line number	Diff line number	Diff line change
`@@ -593,7 +593,7 @@ - (void)menuChangedItem:(NSNotification*)aSender {`
`593`	`593`	`}`
`594`	`594`
`595`	`595`	`NS_IMETHODIMP nsFilePicker::GetFiles(nsISimpleEnumerator** aFiles) {`
`596`		`- return NS_NewArrayEnumerator(aFiles, mFiles);`
	`596`	`+ return NS_NewArrayEnumerator(aFiles, mFiles, NS_GET_IID(nsIFile));`
`597`	`597`	`}`
`598`	`598`
`599`	`599`	`NS_IMETHODIMP nsFilePicker::SetDefaultString(const nsAString& aString) {`