Skip to content

Commit 87cb3dd

Browse files
authored
chore: Re-enable Playwright tests for mars image proxy fix, and update configs for new dep versions (#155)
* Update react example next.config and start script for new next version * Reinstall node modules * Tweak selector alt text * Re-enable playwright tests now that mars image proxy returns 500s for non-image content types
1 parent 2906502 commit 87cb3dd

File tree

6 files changed

+28
-40
lines changed

6 files changed

+28
-40
lines changed

.github/workflows/cross_browser_e2e_test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ on:
88
branches: [ main ]
99
jobs:
1010
cross_browser_e2e_test:
11-
if: false
1211
name: cross browser e2e test
1312
timeout-minutes: 20
1413
runs-on: ubuntu-latest

examples/react/next.config.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@ import type { NextConfig } from "next"
22
import path from "path"
33

44
const nextConfig: NextConfig = {
5-
experimental: {
6-
turbo: {
7-
root: path.resolve(__dirname, "../../"),
8-
},
5+
turbopack: {
6+
root: path.resolve(__dirname, "../../"),
97
},
8+
outputFileTracingRoot: __dirname,
109
}
1110

1211
export default nextConfig

examples/react/package-lock.json

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.1.0",
44
"private": true,
55
"scripts": {
6-
"dev": "next dev --turbopack",
6+
"dev": "next dev",
77
"build": "next build",
88
"start": "next start"
99
},

examples/tests/helpers.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ const getBoundingRectangle = async (locator: Locator): Promise<DOMRect> => {
6666

6767
const altTexts = {
6868
tile: "Mozilla Ad",
69-
billboard_1: "Brand Text mock_pocket_billboard_1 0",
70-
billboard_2: "Brand Text mock_pocket_billboard_2 0",
71-
skyscraper_1: "Brand Text mock_pocket_skyscraper_1 0",
72-
skyscraper_2: "Brand Text mock_pocket_skyscraper_2 0",
73-
rectangle_1: "Brand Text mock_pocket_rectangle_1 0",
74-
rectangle_2: "Brand Text mock_pocket_rectangle_2 0",
69+
billboard_1: "Brand Text mock_pocket_billboard_1, 0",
70+
billboard_2: "Brand Text mock_pocket_billboard_2, 0",
71+
skyscraper_1: "Brand Text mock_pocket_skyscraper_1, 0",
72+
skyscraper_2: "Brand Text mock_pocket_skyscraper_2, 0",
73+
rectangle_1: "Brand Text mock_pocket_rectangle_1, 0",
74+
rectangle_2: "Brand Text mock_pocket_rectangle_2, 0",
7575
}
7676

7777
export { altTexts, expectAdLayout, expectClickNavigation }

package-lock.json

Lines changed: 18 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)