File tree Expand file tree Collapse file tree 1 file changed +0
-3
lines changed
merino/curated_recommendations Expand file tree Collapse file tree 1 file changed +0
-3
lines changed Original file line number Diff line number Diff line change @@ -608,7 +608,6 @@ def pick_random_fresh_story(
608608 """Pick a random fresh story (not blocked from most popular). The chance of picking a fresh story is based on the number of leftover
609609 impressions after accounting for max impressions per item, and the number of items. The number of
610610 impressions in a period is max_imp_per_item_per_cycle.
611-
612611 Returns an picked story, and the remaining items, with the story removed if one was picked.
613612 Args:
614613 items: List of CuratedRecommendation objects
@@ -624,7 +623,6 @@ def pick_random_fresh_story(
624623 )
625624 if len (fresh_items ) == 0 :
626625 return None , items
627-
628626 total_remaining = sum (
629627 it .ranking_data .remaining_impressions if it .ranking_data else 0 for it in fresh_items
630628 )
@@ -642,7 +640,6 @@ def pick_random_fresh_story(
642640 it .ranking_data .remaining_impressions if it .ranking_data else 0 for it in fresh_items
643641 ]
644642 picked = random .choices (fresh_items , weights = weights , k = 1 )[0 ]
645-
646643 # Remove the picked object from the original items list
647644 remaining_items = [it for it in items if it is not picked ]
648645 return picked , remaining_items
You can’t perform that action at this time.
0 commit comments