[DISCO-4020] engagement data check (#1355)

Author: tiftran

merino/providers/suggest/adm/provider.py

@@ -221,6 +221,8 @@ def _is_thompson_eligible(self, client_variants: list[str]) -> bool:
         """Return True if Thompson sampling should be applied to this request."""
         if not self.thompson:
             return False
+        if not self.engagement_data.amp:
+            return False
         if self.should_check_client_variants:
             return any(cv in CLIENT_VARIANTS_ALLOW_LIST for cv in client_variants)
         return True

tests/unit/providers/suggest/adm/conftest.py

@@ -317,12 +317,20 @@ def fixture_adm_with_thompson_single_candidate_below_threshold(
     adm_parameters: dict[str, Any],
     thompson_sampler_with_dummy: ThompsonSampler,
     statsd_mock: Any,
+    engagement_data: EngagementData,
 ) -> Provider:
     """Create an AdM Provider with Thompson sampling and a min_attempted_count threshold."""
-    return Provider(
+    provider = Provider(
         backend=backend_mock,
         metrics_client=statsd_mock,
         min_attempted_count=1000,
         thompson=thompson_sampler_with_dummy,
         **adm_parameters,
     )
+    provider.engagement_data = EngagementData(
+        amp={
+            "Example.org": {"click": 10, "impression": 100},
+        },
+        amp_aggregated={},
+    )
+    return provider

tests/unit/providers/suggest/adm/test_provider_thompson.py

@@ -12,6 +12,7 @@
 from merino.middleware.geolocation import Location
 from merino.middleware.user_agent import UserAgent
 from merino.optimizers.thompson import ThompsonSampler
+from merino.providers.suggest.adm.backends.protocol import EngagementData
 from merino.providers.suggest.adm.provider import NonsponsoredSuggestion, Provider
 
 from tests.unit.types import SuggestionRequestFixture
@@ -75,6 +76,9 @@ async def test_query_with_thompson_dummy_suppresses_suggestion(
 ) -> None:
     """Provider with a dominant dummy should suppress the suggestion (return empty list)."""
     await adm_with_thompson_dummy.initialize()
+    adm_with_thompson_dummy.engagement_data = EngagementData(
+        amp={"something": {}}, amp_aggregated={}
+    )
 
     res = await adm_with_thompson_dummy.query(
         srequest("firefox", GEOLOCATION, USER_AGENT, CLIENT_VARIANTS)
@@ -216,3 +220,36 @@ async def test_query_with_thompson_single_candidate_below_threshold_returns_sugg
     statsd_mock.increment.assert_called_once_with(
         "providers.adm.thompson.select", tags={"outcome": "skipped"}
     )
+
+
+@pytest.mark.asyncio
+async def test_query_with_thompson_without_engagement_data_skips_sampling(
+    srequest: SuggestionRequestFixture,
+    adm_with_thompson_dummy: Provider,
+    adm_parameters: dict[str, Any],
+    statsd_mock: Any,
+) -> None:
+    """Provider should skip Thompson sampling when engagement data is empty."""
+    await adm_with_thompson_dummy.initialize()
+
+    res = await adm_with_thompson_dummy.query(
+        srequest("firefox", GEOLOCATION, USER_AGENT, CLIENT_VARIANTS)
+    )
+
+    assert res == [
+        NonsponsoredSuggestion(
+            block_id=2,
+            full_keyword="firefox accounts",
+            title="Mozilla Firefox Accounts",
+            url=HttpUrl("https://example.org/target/mozfirefoxaccounts"),
+            categories=[],
+            impression_url=HttpUrl("https://example.org/impression/mozilla"),
+            click_url=HttpUrl("https://example.org/click/mozilla"),
+            provider="adm",
+            advertiser="Example.org",
+            is_sponsored=False,
+            icon="attachment-host/main-workspace/quicksuggest/icon-01",
+            score=adm_parameters["score"],
+        )
+    ]
+    statsd_mock.increment.assert_not_called()