From 652c19c7c5fed9066cb2d92a8305fbc82ece04b4 Mon Sep 17 00:00:00 2001 From: Nan Jiang Date: Mon, 30 Mar 2026 17:54:41 -0400 Subject: [PATCH] [DISCO-4026] fix: Fix casing for engagement lookups --- merino/providers/suggest/adm/provider.py | 2 +- tests/unit/providers/suggest/adm/conftest.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/merino/providers/suggest/adm/provider.py b/merino/providers/suggest/adm/provider.py index 3f60fb5a2..354454880 100644 --- a/merino/providers/suggest/adm/provider.py +++ b/merino/providers/suggest/adm/provider.py @@ -210,7 +210,7 @@ def normalize_query(self, query: str) -> str: def _fetch_engagement_metrics(self, suggestion: PyAmpResult) -> EngagementMetrics: """Fetch engagement metrics for an AMP suggestion.""" - advertiser = suggestion.advertiser + advertiser = suggestion.advertiser.lower() engaged, attempted = 1, 1 if self.engagement_data and (metrics := self.engagement_data.amp.get(advertiser)): attempted = int(metrics.get("impressions", attempted)) diff --git a/tests/unit/providers/suggest/adm/conftest.py b/tests/unit/providers/suggest/adm/conftest.py index 91ba81bae..f68d0dc8f 100644 --- a/tests/unit/providers/suggest/adm/conftest.py +++ b/tests/unit/providers/suggest/adm/conftest.py @@ -216,12 +216,12 @@ def fixture_engagement_data() -> EngagementData: "clicks": 5, }, "Example.org": { - "advertiser": "Example.org", + "advertiser": "example.org", "impressions": 10001, "clicks": 10000, }, "LowEngagement": { - "advertiser": "LowEngagement", + "advertiser": "lowengagement", "impressions": 9999, "clicks": 5, }, @@ -329,7 +329,7 @@ def fixture_adm_with_thompson_single_candidate_below_threshold( ) provider.engagement_data = EngagementData( amp={ - "Example.org": {"click": 10, "impression": 100}, + "example.org": {"click": 10, "impression": 100}, }, amp_aggregated={}, )