Speedup tests (#1656)

leplatrem · web-flow · commit 6b5616d771ff · 2025-12-16T17:29:51.000+01:00
diff --git a/telescope/utils.py b/telescope/utils.py
@@ -223,7 +223,7 @@ def __aexit__(self, *args):
 retry_decorator = backoff.on_exception(
     backoff.expo,
     (aiohttp.ClientError, asyncio.TimeoutError),
-    max_tries=config.REQUESTS_MAX_RETRIES + 1,  # + 1 because REtries.
+    max_tries=lambda: config.REQUESTS_MAX_RETRIES + 1,  # + 1 because REtries.
 )
 
 
diff --git a/tests/checks/core/test_heartbeat.py b/tests/checks/core/test_heartbeat.py
@@ -21,7 +21,8 @@ async def test_negative(mock_aioresponses):
     assert data == {}
 
 
-async def test_unreachable(mock_aioresponses):
+async def test_unreachable(mock_aioresponses, config):
+    config.REQUESTS_MAX_RETRIES = 0
     status, data = await run("http://not-mocked")
 
     assert status is False
diff --git a/tests/checks/core/test_readthedocs.py b/tests/checks/core/test_readthedocs.py
@@ -209,13 +209,13 @@ async def test_negative_not_recent_and_not_matching(mock_aioresponses):
 
 
 @pytest.mark.asyncio
-async def test_bad_content_type(mock_aioresponses):
+async def test_bad_content_type(mock_aioresponses, config):
+    config.REQUESTS_MAX_RETRIES = 0
     mock_aioresponses.get(
         "https://readthedocs.org/api/v3/projects/remote-settings/versions/",
         body="<html>Not JSON</html>",
         content_type="text/html",
         status=403,
-        repeat=True,
     )
 
     with pytest.raises(aiohttp.client_exceptions.ContentTypeError) as excinfo:
diff --git a/tests/test_basic_endpoints.py b/tests/test_basic_endpoints.py
@@ -47,7 +47,12 @@ async def test_heartbeat(cli, config, mock_aioresponses):
     assert response.status == 200
 
 
-async def test_heartbeat_cache(cli, config):
+async def test_heartbeat_cache(cli, config, mock_aioresponses):
+    config.BUGTRACKER_URL = "http://bugzilla.local"
+    mock_aioresponses.get(
+        config.BUGTRACKER_URL + "/rest/whoami", payload={"name": "foo"}, repeat=True
+    )
+
     response = await cli.get("/__heartbeat__")
     body = await response.json()
     assert body["cache"] == "ok"
@@ -300,7 +305,10 @@ def __call__(self, url, **kwargs):
 
 async def test_check_force_refresh(cli, mock_aioresponses):
     mock_aioresponses.get(
-        "http://server.local/__heartbeat__", status=200, payload={"ok": True}
+        "http://server.local/__heartbeat__",
+        status=200,
+        payload={"ok": True},
+        repeat=True,
     )
 
     resp = await cli.get("/checks/testproject/hb")

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ def __aexit__(self, *args):`
`223`	`223`	`retry_decorator = backoff.on_exception(`
`224`	`224`	`backoff.expo,`
`225`	`225`	`(aiohttp.ClientError, asyncio.TimeoutError),`
`226`		`- max_tries=config.REQUESTS_MAX_RETRIES + 1, # + 1 because REtries.`
	`226`	`+ max_tries=lambda: config.REQUESTS_MAX_RETRIES + 1, # + 1 because REtries.`
`227`	`227`	`)`
`228`	`228`
`229`	`229`